Integrate go-nvtrust to collect GPU attestation#676
Merged
yawangwang merged 1 commit intogoogle:mainfrom Feb 27, 2026
Merged
Conversation
yawangwang
force-pushed
the
integrate_go_nvtrust_h100
branch
4 times, most recently
from
c250cfe to
14cc828
Compare
alexmwu
reviewed
Feb 25, 2026
launcher/agent/agent.go
Outdated
| return finalNonce[:] | ||
| } | ||
|
|
||
| func (t *tdxAttestRoot) GetDeviceAttestation(nonce []byte) (*verifier.DeviceAttestation, error) { |
Contributor
There was a problem hiding this comment.
I wonder if we should have a separate device RoT. It seems strange to have this be a method under the TDX attestation root.
Contributor
There was a problem hiding this comment.
The logic in my mind goes like:
- Launcher already detects supported devices due to drivers.
- Launcher installs drivers but does not put GPU into ready state.
- Launcher calls MeasureEvent with the GPU's DeviceAttestation proto.
- Launcher puts GPUs into ready state.
- Collect attestation evidence for runtime (tbd if needed) in the Attest call
Collaborator
Author
There was a problem hiding this comment.
That's also my understanding. Updated the PR to have launcher pass only the supported ones into the attestation agent.
launcher/internal/gpu/attestation.go
Outdated
|
|
||
| // CollectAttestationEvidence assumes CC GPU devices are in place w/ driver support | ||
| // and will try to collect raw attestation evidence and convert it to known data models. | ||
| func CollectAttestationEvidence(handler gpu.NvmlHandler, nonce []byte) (*models.NvidiaAttestation, error) { |
Contributor
There was a problem hiding this comment.
This will need a bit of refactoring to use the protos, but that can be done in a follow-up CL
jkl73
reviewed
Feb 25, 2026
yawangwang
force-pushed
the
integrate_go_nvtrust_h100
branch
3 times, most recently
from
9f0eff2 to
56ead1b
Compare
jkl73
approved these changes
Feb 26, 2026
alexmwu
approved these changes
Feb 27, 2026
yawangwang
force-pushed
the
integrate_go_nvtrust_h100
branch
4 times, most recently
from
24ba60a to
31ef7f4
Compare
yawangwang
force-pushed
the
integrate_go_nvtrust_h100
branch
from
31ef7f4 to
42dc7b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate the OSS library go-nvtrust into tdx attester to collect confidential GPU attestation.