Skip to content

Skip new tests failing on macos-14 #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mtsokol wants to merge 1 commit into from
Closed

Skip new tests failing on macos-14 #1122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion grain/_src/python/dataset/transformations/prefetch_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1171,7 +1171,6 @@ def test_no_mem_leak(self):
for _ in range(5):
_ = next(it)

@absltest.skipIf(platform.system() == 'Darwin', 'Fails on macos-14 runner.')
@parameterized.parameters([True, False])
def test_no_mem_leak_with_double_prefetch(self, close: bool):
ds = (
Expand All @@ -1192,6 +1191,7 @@ def test_no_mem_leak_with_double_prefetch(self, close: bool):
if close:
it.close() # pytype: disable=attribute-error

@absltest.skipIf(platform.system() == 'Darwin', 'Fails on macos-14 runner.')
@parameterized.parameters([True, False])
def test_early_break_continues_prefetching(self, close: bool):
count = 0
Expand Down
2 changes: 2 additions & 0 deletions grain/_src/python/variable_size_queue_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# limitations under the License.
"""Tests for variable size queue implementations."""

import platform
import queue
import threading
import time
Expand Down Expand Up @@ -245,6 +246,7 @@ def _blocking_put():
self.assertEqual(q.get(), 3)
t.join()

@absltest.skipIf(platform.system() == 'Darwin', 'Fails on macos-14 runner.')
def test_put_blocks_until_item_is_retrieved_from_process(self):
ctx = mp.get_context("spawn")
q = variable_size_queue.VariableSizeMultiprocessingQueue(1, ctx=ctx)
Expand Down