Skip to content

Conversation

@andreia-ferreira
Copy link
Collaborator

This PR moves all DI–related files into a dedicated package.
Centralizing DI setup makes dependency relationships easier to understand without searching across scattered packages and helps prepare the codebase for future refactoring and modularization.

No code changes were introduced, only files were moved

@shobhitagarwal1612 @hassan-nsubuga PTAL?

@auto-assign auto-assign bot requested a review from sufyanAbbasi January 30, 2026 11:22
@andreia-ferreira andreia-ferreira requested review from hassan-nsubuga and shobhitagarwal1612 and removed request for sufyanAbbasi January 30, 2026 11:22
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @andreia-ferreira, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the project's structure by relocating all Dependency Injection (DI) related files into a new, dedicated di package. This strategic move aims to enhance the clarity and maintainability of the codebase by centralizing DI configurations, thereby simplifying the understanding of dependency relationships and preparing the application for future modularization efforts. The changes are purely organizational, with no alterations to the application's functionality.

Highlights

  • Dependency Injection (DI) Package Restructuring: All files related to Dependency Injection (DI) have been moved into a new, dedicated org.groundplatform.android.di package, including sub-packages like org.groundplatform.android.di.coroutines.
  • Improved Code Organization: This refactoring centralizes the DI setup, making dependency relationships clearer and easier to understand by consolidating related files into a single logical location.
  • No Functional Changes: The pull request explicitly states that no functional code changes were introduced; the changes are purely structural, involving file moves and corresponding import path updates.
  • Updated Import Paths: Numerous files across the codebase have been updated to reflect the new package structure for the moved DI modules and related components.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request does an excellent job of refactoring the dependency injection files into a dedicated di package. This centralization greatly improves the project's structure and makes dependency relationships easier to manage. The changes are primarily file moves and import updates, which have been handled cleanly across the codebase. I've added one minor suggestion to improve KDoc readability. Overall, this is a solid and valuable refactoring.

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.82%. Comparing base (207d9db) to head (43a3958).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3498   +/-   ##
=========================================
  Coverage     69.82%   69.82%           
  Complexity     1599     1599           
=========================================
  Files           322      322           
  Lines          8678     8678           
  Branches        949      949           
=========================================
  Hits           6059     6059           
  Misses         2049     2049           
  Partials        570      570           
Files with missing lines Coverage Δ
...android/data/remote/firebase/FirestoreDataStore.kt 0.00% <ø> (ø)
...tform/android/data/sync/LocalMutationSyncWorker.kt 95.65% <ø> (ø)
...undplatform/android/data/sync/MediaUploadWorker.kt 85.71% <ø> (ø)
...oundplatform/android/data/sync/SurveySyncWorker.kt 100.00% <ø> (ø)
...undplatform/android/repository/SurveyRepository.kt 87.80% <ø> (ø)
.../groundplatform/android/system/GeocodingManager.kt 92.50% <ø> (ø)
...g/groundplatform/android/system/LocationManager.kt 100.00% <ø> (ø)
...roid/system/auth/AnonymousAuthenticationManager.kt 0.00% <ø> (ø)
...android/system/auth/GoogleAuthenticationManager.kt 0.00% <ø> (ø)
...droid/ui/datacollection/DataCollectionViewModel.kt 79.04% <ø> (ø)
... and 5 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@andreia-ferreira andreia-ferreira merged commit 0a8d0d6 into master Jan 30, 2026
9 checks passed
@andreia-ferreira andreia-ferreira deleted the andreia/sort-di branch January 30, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants