Fix trending ConverterExtKt crash

[andreia-ferreira]

Fixes #3509

If a job was removed from a survey while a user had a draft locally, the app would repetitively crash when trying to restore the draft on startup. The only way to fix that state then would be to clear the local data.

This was due to the fact that a LocalDataConsistencyException was being thrown by DraftSubmissionEntity.toModelObject() when the referenced job no longer exists. This exception should be used in case of a unexpected data corruption, a job being deleted should be handled gracefully. By changing the method to return null the draft won't be forced to load anymore and the app won't crash

@shobhitagarwal1612 PTAL?

[gemini-code-assist]

Summary of Changes

Hello @andreia-ferreira, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical crash that occurred when a user had a local draft submission referencing a job that was subsequently removed from a survey. Previously, attempting to restore such a draft would lead to repetitive app crashes on startup, requiring users to clear local data. The changes ensure that the application gracefully handles these inconsistent drafts by discarding them, thereby preventing crashes and improving user experience.

Highlights

• Graceful Draft Handling: Modified the DraftSubmissionEntity.toModelObject function to return null when a draft references a non-existent job, preventing app crashes.
• Exception Removal: Replaced the throwing of LocalDataConsistencyException with a graceful null return for draft submissions where the referenced job ID is missing.
• New Test Case: Added a unit test to confirm that drafts referencing missing jobs are correctly discarded (by returning null) instead of causing errors.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively resolves a crash that occurred when trying to restore a draft submission for a job that no longer exists. The change from throwing a LocalDataConsistencyException to gracefully handling the situation by returning null in DraftSubmissionEntity.toModelObject is a robust solution. The addition of a warning log is also helpful for debugging. The new test case in DataCollectionFragmentTest thoroughly validates the fix by simulating the scenario of a missing job and asserting the expected null result. The changes are well-implemented and improve the application's stability.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.85%. Comparing base (b08fea8) to head (5a97634).

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #3511      +/-   ##
============================================
+ Coverage     69.82%   69.85%   +0.02%     
  Complexity     1599     1599              
============================================
  Files           322      322              
  Lines          8678     8680       +2     
  Branches        949      949              
============================================
+ Hits           6059     6063       +4     
+ Misses         2049     2048       -1     
+ Partials        570      569       -1     

Files with missing lines	Coverage Δ
.../android/data/local/room/converter/ConverterExt.kt	84.76% <100.00%> (+0.73%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.