Fix issue 3541, Can't complete polygon after getting an interception error popup

[hassan-nsubuga]

complete.polygon.after.inter.section.error.mp4

Fixes #3541

Can't complete polygon after getting an interception error popup, this happens after getting the intersection error and it's not possible to complete a polygon unless a new point is added.
Reset hasSelfIntersection to false after an intersection error to enable the completion button in order to complete a polygon without adding a new point

• Refactor DrawAreaTaskViewModel to reset value for hasSelfIntersection to false in updateVertices method
• Call updateVertices to handle vertices update from checkVertexIntersection
• Add tests to DrawAreaTaskViewModelTest to cover the above modifications
• Change showSelfIntersectionDialog to state flow to aid in showing the intersection error dialog for the user to take action event after screen rotation.

@... PTAL?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.93%. Comparing base (b5f9e48) to head (5cb0e85).

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #3606      +/-   ##
============================================
+ Coverage     68.81%   68.93%   +0.12%     
- Complexity     1826     1831       +5     
============================================
  Files           355      355              
  Lines          8577     8578       +1     
  Branches       1076     1076              
============================================
+ Hits           5902     5913      +11     
+ Misses         2037     2031       -6     
+ Partials        638      634       -4     

Files with missing lines	Coverage Δ
...acollection/tasks/polygon/DrawAreaTaskViewModel.kt	86.51% <100.00%> (+5.72%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug preventing users from completing a polygon after a self-intersection error. By ensuring the hasSelfIntersection flag is correctly reset when vertices are updated, the changes restore the ability to finalize polygon drawing without requiring additional, unnecessary points. This improves the user experience by making the polygon drawing tool more robust and predictable.

Highlights

• Polygon Completion Fix: Resolved an issue where users could not complete a polygon after encountering a self-intersection error without adding a new point.
• Refactored Vertex Handling: Modified the checkVertexIntersection method to utilize updateVertices when removing the last vertex after a self-intersection, ensuring consistent state management.
• hasSelfIntersection Reset: Implemented a reset of the hasSelfIntersection flag to false within the updateVertices method, enabling the completion button after an intersection error.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• app/src/main/java/org/groundplatform/android/ui/datacollection/tasks/polygon/DrawAreaTaskViewModel.kt
  • Changed checkVertexIntersection to call updateVertices when dropping the last vertex.
  • Added hasSelfIntersection = false to the updateVertices method.

Activity

• The pull request was created to address issue [Draw area] Can't complete polygon after getting an interception error popup #3541, which describes the inability to complete a polygon after a self-intersection error popup.
• No specific review comments or discussions have been recorded yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The DrawAreaTaskViewModel was updated to ensure that when a self-intersecting polygon's last vertex is removed, the hasSelfIntersection flag is explicitly reset to false within the updateVertices method, which is now consistently used for all vertex list modifications.

[andreia-ferreira]

unused code can be removed

[andreia-ferreira]

this is only used inside the VM so it can be private

[andreia-ferreira]

suggestion: not related to this PR, so feel free to resolve this commen, but maybe a clearer name for this method would be showSelfIntersectionDialog

[andreia-ferreira]

when overriding the main test dispatcher, it should be reset otherwise it may leak into other tests. I suggest adding the following to the test file to prevent it:

  @After
  fun tearDown() {
    Dispatchers.resetMain()
  }