Fix pnpm monorepo isolation logic

[rfontanarosa]

closes #2414

[gemini-code-assist]

Summary of Changes

Hello @rfontanarosa, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the pnpm monorepo isolation logic, specifically impacting Firebase function deployments. The changes streamline the deployment process by introducing a more explicit and robust predeploy script for functions, ensuring dependencies are correctly isolated and installed. It also incorporates a new Google Cloud dependency and standardizes the Firebase deployment command, alongside general dependency updates to maintain project health and compatibility.

Highlights

• Enhanced Firebase Function Deployment: The predeploy script for Firebase functions in firebase.json has been updated to a two-step process. It now first isolates the package using npx isolate-package and then performs a pnpm install with specific flags (--prod --no-frozen-lockfile --shamefully-hoist --ignore-workspace) to ensure proper production dependency management and workspace isolation.
• New Google Cloud Dependency: The @google-cloud/functions-framework package has been added as a new dependency in functions/package.json and pnpm-lock.yaml, indicating potential new or updated Firebase function capabilities.
• Standardized Deployment Command: A default deploy command has been introduced within the nx:run-commands executor options in package.json, standardizing the Firebase deployment command to firebase deploy --config firebase.json --project ground-dev-sig.
• Dependency Updates and Clean-up: Numerous package versions have been updated and some removed across pnpm-lock.yaml and pnpm-workspace.yaml. Key updates include isolate-package, @npmcli/arborist, @npmcli/config, and various @types packages. The eslint-plugin-n override was also removed from package.json.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.26%. Comparing base (efdf193) to head (a0a2355).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2415   +/-   ##
=======================================
  Coverage   59.26%   59.26%           
=======================================
  Files         115      115           
  Lines        2872     2872           
  Branches      430      430           
=======================================
  Hits         1702     1702           
  Misses       1110     1110           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[gemini-code-assist]

Code Review

This pull request addresses the pnpm monorepo isolation logic, primarily by updating Firebase configuration and package dependencies. The changes involve modifying the predeploy script in firebase.json to use an array of commands and updating various package versions across functions/package.json, package.json, pnpm-lock.yaml, and pnpm-workspace.yaml. While the core intent is clear, there are a few areas that could benefit from refinement, particularly regarding dependency management and configuration clarity.