PGO: Don't re-run benchmarks if their results will be discarded.#11828
Merged
copybara-service[bot] merged 1 commit intomasterfrom Jun 18, 2025
Merged
PGO: Don't re-run benchmarks if their results will be discarded.#11828copybara-service[bot] merged 1 commit intomasterfrom
copybara-service[bot] merged 1 commit intomasterfrom
Conversation
copybara-service
bot
force-pushed
the
test/cl773070831
branch
from
c3b2e2b to
27219c1
Compare
This moves the "should this be skipped?" logic earlier in the pipeline so that it can be used prior to running benchmarks at all, which consume a bunch of machine-hours for no reason if their results will be discarded. BuildKite doesn't seem to have a way for an intermediate step to mark the whole pipeline as skippable, so this refactors the skip logic to its own script that can be used as `skip-or.sh || else_do_this`. Use it in all steps. PiperOrigin-RevId: 773103605
copybara-service
bot
force-pushed
the
test/cl773070831
branch
from
27219c1 to
85c27ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PGO: Don't re-run benchmarks if their results will be discarded.
This moves the "should this be skipped?" logic earlier in the pipeline
so that it can be used prior to running benchmarks at all, which consume
a bunch of machine-hours for no reason if their results will be discarded.
BuildKite doesn't seem to have a way for an intermediate step to mark the
whole pipeline as skippable, so this refactors the skip logic to its own
script that can be used as
skip-or.sh || else_do_this.Use it in all steps.