Fix attempt for flakiness of testDockerComposeBuild test #12559
Merged
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test/cl862805236
branch
from
73d5527 to
fd58825
Compare
copybara-service
bot
changed the title
This test eats the returned error at d.WaitForOutput(ctx, want, defaultWait). Instead of waiting for a certain output that can change in the future, let's check the existence of the image periodically and get rid of this call completely. After removing this call, I did not experience test failures in my testing. Increasing the defaultWait also removed flakiness but I think we should get rid of this check. PiperOrigin-RevId: 862834710
copybara-service
bot
force-pushed
the
test/cl862805236
branch
from
fd58825 to
80a9cb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix attempt for flakiness of testDockerComposeBuild test
This test eats the returned error at d.WaitForOutput(ctx, want, defaultWait).
Instead of waiting for a certain output that can change in the future,
let's check the existence of the image periodically and get rid of this call completely. After removing this call, I did not experience test failures in my testing. Increasing the defaultWait also removed flakiness but I think we should get rid of this check.