Open
Conversation
Shift left on aarch64 and others produced:
FAIL (exit code): /builddir/build/BUILD/jsonnet-0.22.0-build/jsonnet-0.22.0/redhat-linux-build/jsonnet --ext-str var1=test --ext-code var2='{x:1,y:2}' error.integer_left_shift_runtime.jsonnet
This run's output:
-9223372036854775808
Actual exit code 0, expected 1
The code now has explicit size and sign handling.
Fixes: google#1315
Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
Collaborator
|
Sigh. Getting this right in C++ remains tricky, apparently, and I wasn't careful enough. Thanks for the fix! |
Contributor
Author
|
Running a test build at : https://koji.fedoraproject.org/koji/taskinfo?taskID=143858182 |
Contributor
Author
|
Test build completed and passed unit tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shift left on aarch64 and others produced:
FAIL (exit code): /builddir/build/BUILD/jsonnet-0.22.0-build/jsonnet-0.22.0/redhat-linux-build/jsonnet --ext-str var1=test --ext-code var2='{x:1,y:2}' error.integer_left_shift_runtime.jsonnet This run's output:
-9223372036854775808
Actual exit code 0, expected 1
The code now has explicit size and sign handling.
Fixes: #1315