Skip to content

blocks: add double single quote block recognition#78

Merged
JeffFaer merged 1 commit intogoogle:mainfrom
katexochen:double-single-quote-blocks
Apr 1, 2025
Merged

blocks: add double single quote block recognition#78
JeffFaer merged 1 commit intogoogle:mainfrom
katexochen:double-single-quote-blocks

Conversation

@katexochen
Copy link
Copy Markdown
Contributor

Nix multi line strings use double single quotes. Adding this to the list of quotes that indicate blocks.

Signed-off-by: Paul Meyer <katexochen0@gmail.com>
@katexochen katexochen force-pushed the double-single-quote-blocks branch from 7403d9d to a523474 Compare March 27, 2025 10:06
@katexochen
Copy link
Copy Markdown
Contributor Author

@JeffFaer for review. :)

@JeffFaer JeffFaer enabled auto-merge (squash) April 1, 2025 16:02
@JeffFaer JeffFaer self-requested a review April 1, 2025 16:02
@JeffFaer
Copy link
Copy Markdown
Collaborator

JeffFaer commented Apr 1, 2025

Thanks for the PR!

@JeffFaer JeffFaer merged commit 1e5a257 into google:main Apr 1, 2025
5 checks passed
@katexochen katexochen deleted the double-single-quote-blocks branch April 1, 2025 16:05
@JeffFaer
Copy link
Copy Markdown
Collaborator

Hmm, so I wasn't thinking about it back in April, but '' is also how many languages express an empty string, which shouldn't be treated as a quote. I think we might want to revert this PR, and maybe allow the list of quotes to be customized via a flag or something

JeffFaer added a commit that referenced this pull request Aug 14, 2025
JeffFaer added a commit that referenced this pull request Aug 14, 2025
This reverts commit 1e5a257.

`''` is also how many languages express an empty string, which shouldn't
be treated as a quote. #78 causes quite a few problems for many files
internally, and I assume it'd also cause problems externally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants