Skip to content

feat: Change newline_separated support multiple newlines #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JeffFaer merged 2 commits into from
Aug 14, 2025
Merged

feat: Change newline_separated support multiple newlines #84

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3cb384
feat: Change newline_separated to a new IntOrBool type to support mul…
joesun-google Jul 12, 2025
04da95c
feat: Change newline_separated to a new IntOrBool type to support mul…
joesun-google Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion keepsorted/options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ func validate(opts *blockOptions) (warnings []error) {
}

if opts.NewlineSeparated < 0 {
warns = append(warns, fmt.Errorf("newline_separated has invalid value: %v", opts.SkipLines))
warns = append(warns, fmt.Errorf("newline_separated has invalid value: %v", opts.NewlineSeparated))
opts.NewlineSeparated = 0
}

Expand Down
11 changes: 6 additions & 5 deletions keepsorted/options_parser_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,22 +225,23 @@ func TestPopValue(t *testing.T) {
want: []*regexp.Regexp{regexp.MustCompile(".*"), regexp.MustCompile("abcd"), regexp.MustCompile("(?:efgh)ijkl")},
},
{
name: "Newlines",
name: "IntOrBool_Int",

input: "5",
want: IntOrBool(5),
},
{
name: "Newlines_BoolTrue",
name: "IntOrBool_True",
input: "yes",
want: IntOrBool(1),
},
{
name: "Newlines_BoolFalse",
name: "IntOrBool_False",
input: "no",
want: IntOrBool(0),
}, {
name: "Newlines_Invalid",
},
{
name: "IntOrBool_Invalid",

input: "foo",
want: IntOrBool(0),
Expand Down
12 changes: 12 additions & 0 deletions keepsorted/options_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,18 @@ func TestBlockOptions(t *testing.T) {

want: blockOptions{NewlineSeparated: 1},
},
{
name: "NewlineSeparated_Int",
in: "newline_separated=10",

want: blockOptions{NewlineSeparated: 10},
},
{
name: "NewlineSeparated_Invalid",
in: "newline_separated=-1",

wantErr: "newline_separated has invalid value: -1",
},
{
name: "ErrorSkipLinesIsNegative",
in: "skip_lines=-1",
Expand Down
Loading