Skip to content

Add missing template args list after the use of the template keyword #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add missing template args list after the use of the template keyword #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72e5777
Add missing template args list after the use of the template keyword
FMarno Apr 23, 2025
64257cd
fixup! Add missing template args list after the use of the template k…
FMarno Apr 23, 2025
b1d0ffa
fixup! Add missing template args list after the use of the template k…
FMarno Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/nop/rpc/interface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,8 @@ struct InterfaceMethod {
template <typename Sender>
static void Invoke(Sender* sender, Status<Return>* return_value,
Args... args) {
sender->template SendMethod(InterfaceMethod::Selector, return_value,
std::forward_as_tuple(args...));
sender->template SendMethod<>(InterfaceMethod::Selector, return_value,
std::forward_as_tuple(args...));
}

// Dispatches the given handler op, getting the arguments from the given
Expand Down
7 changes: 4 additions & 3 deletions include/nop/types/variant.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ class Variant {
// resulting type.
template <typename... Args>
void Construct(Args&&... args) {
index_ = value_.template Construct(std::forward<Args>(args)...);
index_ = value_.template Construct<>(std::forward<Args>(args)...);
}
void Construct(EmptyVariant) {}

Expand All @@ -255,14 +255,15 @@ class Variant {
// multiple element types.
template <typename T, typename U>
void Assign(TypeTag<T>, U&& value) {
if (!value_.template Assign(TypeTag<T>{}, index_, std::forward<U>(value))) {
if (!value_.template Assign<>(TypeTag<T>{}, index_,
std::forward<U>(value))) {
Destruct();
Construct(TypeTag<T>{}, std::forward<U>(value));
}
}
template <typename T>
void Assign(T&& value) {
if (!value_.template Assign(index_, std::forward<T>(value))) {
if (!value_.template Assign<>(index_, std::forward<T>(value))) {
Destruct();
Construct(std::forward<T>(value));
}
Expand Down