fix memory leak in fuzz_matcher.cc#3847
Merged
mandlil merged 1 commit intogoogle:masterfrom Apr 22, 2025
Merged
Conversation
Contributor
Author
|
@tvislavski @mandlil Tests in oss-fuzz detected a small memory leak in the fuzzer, this PR fixes it. |
mandlil
approved these changes
Apr 17, 2025
Contributor
Author
|
@tvislavski Can you review and merge? |
Contributor
Author
|
Thank you! Is anything standing in our way of merging this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a simple memory leak in fuzz_matcher.cc. Mentioned in google/oss-fuzz#13227
Leak happens because we don't free the ICURegExpFactory