Add true and false as operands of is and is not#67
Merged
ochafik merged 3 commits intogoogle:mainfrom May 15, 2025
Merged
Conversation
grf53
added a commit
to grf53/minja
that referenced
this pull request
May 6, 2025
Contributor
|
@grf53 thanks, and sorry for the review delay! |
ochafik
added a commit
to ggml-org/llama.cpp
that referenced
this pull request
May 15, 2025
* minja: sync google/minja@f06140f - google/minja#67 (@grf53) - google/minja#66 (@taha-yassine) - google/minja#63 (@grf53) - google/minja#58 --------- Co-authored-by: ochafik <ochafik@google.com>
justinryan-0923
pushed a commit
to justinryan-0923/llama.cpp
that referenced
this pull request
May 30, 2025
* minja: sync google/minja@f06140f - google/minja#67 (@grf53) - google/minja#66 (@taha-yassine) - google/minja#63 (@grf53) - google/minja#58 --------- Co-authored-by: ochafik <ochafik@google.com>
ochafik
added a commit
to ochafik/minja
that referenced
this pull request
Nov 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #64, some operators in Qwen3's template are not supported yet on latest minja.
#66 fixes most of them, but I found another problem during my tests on Qwen3.
I wanted to disable 'thinking' at all in Qwen3, by passing over
inputs.extra_context = {{"enable_thinking", "false"}};, then I gotUnknown type for 'is' operator: false.So I needed to add
"false"as possible name of rhs ofisoperator. ("true"must be one too, so added it too.)After I applied these changes and #66, I finally succeeded to run templating for Qwen3's in my case.
Tests for these changes are also added.