Skip to content

Fix inlining demo after Fuchsia toolchain updates #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions docs/inlining-demo/demo.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,30 @@ export LLVM_SRCDIR=~/llvm-project
export LLVM_INSTALLDIR=~/llvm-install
```

### LLVM Dependencies

The LLVM toolchain that Fuchsia uses has a couple additionaly dependencies,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The LLVM toolchain that Fuchsia uses has a couple additionaly dependencies,
The LLVM toolchain that Fuchsia uses has a couple of additional dependencies,

namely [cpp-httplib](https://github.com/yhirose/cpp-httplib). First off,
set a directory where the cpp-httplib install will go:

```shell
export CPPHTTPLIB_SRC_DIR=~/cpphttplib
export CPPHTTPLIB_INSTALL_DIR=~/cpp-httplib-install
```

Then clone the repository and build:

```shell
git clone https://github.com/yhirose/cpp-httplib $CPPHTTPLIB_SRC_DIR
mkdir $CPPHTTPLIB_SRC_DIR/build
cd $CPPHTTPLIB_SRC_DIR/build
cmake -GNinja \
-DHTTPLIB_NO_EXCEPTIONS=ON \
-DCMAKE_INSTALL_PREFIX=$CPPHTTPLIB_INSTALL_DIR \
../
ninja install
```

### Fuchsia

See instructions at https://fuchsia.dev/fuchsia-src/get-started/get_fuchsia_source. Make sure `PATH` is set up appropriately.
Expand Down Expand Up @@ -144,6 +168,7 @@ cmake -G Ninja \
-DFUCHSIA_SDK=${IDK_DIR} \
-DCMAKE_INSTALL_PREFIX= \
-DCMAKE_INSTALL_RPATH_USE_LINK_PATH=On \
-Dhttplib_ROOT=$CPPHTTPLIB_INSTALL_DIR \
-C ${LLVM_SRCDIR}/clang/cmake/caches/Fuchsia-stage2.cmake \
-C ${TFLITE_PATH}/tflite.cmake \
${LLVM_SRCDIR}/llvm
Expand Down