Disable pytype pyi-error globally #459
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch disable pyi-error globally. We have a lot of manual disables for this error sprinkled throughout the codebase, to the point where we should just disable it globally given the noise that it causes.
|
would that let unwanted errors - i.e. cases we expect a pyi - just pass the type checker? |
Yes, but I'm not sure it's practically an issue. Pytype complains about this because it needs pyi files to obtain some information it needs for type checking. They exist in the vast majority of cases, but in some (with complex imports/module provides it seems), it just errors out. Given that every single error would require upstream refactoring or fixes in pytype and we've just been disabling them, I figured a global override would be reduce (the mostly useless) noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch disable pyi-error globally. We have a lot of manual disables for this error sprinkled throughout the codebase, to the point where we should just disable it globally given the noise that it causes.