Pipfile.lock specific to the python version#535
Conversation
boomanaiden154
left a comment
There was a problem hiding this comment.
What is the purpose of updating the lockfile now?
It also looks like the Dockerfile should be in a separate PR?
|
boomanaiden154
left a comment
There was a problem hiding this comment.
I'm not a big fan of a python wrapper around pipenv, and would probably prefer we just add directions to manually copy the pipfile, but I guess this works for now.
Or maybe we switch to another similar mechanism that supports this scenario (if it exists)? |
After #535, it's easier to just clone the repo to install the dependencies.
After #535, it's easier to just clone the repo to install the dependencies.
Some packages, e.g.
dm-reverb, have different hashes between 3.10 and 3.11. This patch separatesPipfile.lockinto per-version files, and adds a wrapper,versioned_pipenv, that uses the version-specific lock file. It does so by copying the version-specificPipfile.lockin the repo root. Note that we gitingore that name, as it becomes a temporary artifact of runningversioned_pipenv.We could have made the copy elsewhere, but that makes certain variants of
pipenvsubcommands (likerun) not work.