Skip to content

Conversation

@mtrofin
Copy link
Collaborator

@mtrofin mtrofin commented Dec 17, 2025

Some packages, e.g. dm-reverb, have different hashes between 3.10 and 3.11. This patch separates Pipfile.lock into per-version files, and adds a wrapper, versioned_pipenv, that uses the version-specific lock file. It does so by copying the version-specific Pipfile.lock in the repo root. Note that we gitingore that name, as it becomes a temporary artifact of running versioned_pipenv.

We could have made the copy elsewhere, but that makes certain variants of pipenv subcommands (like run) not work.

Copy link
Collaborator

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of updating the lockfile now?

It also looks like the Dockerfile should be in a separate PR?

@mtrofin
Copy link
Collaborator Author

mtrofin commented Dec 17, 2025

What is the purpose of updating the lockfile now?
the pipenv sync in the (now removed from this PR) demo Dockerfile isn't happy about some dependencies.

It also looks like the Dockerfile should be in a separate PR?
yes, fumbled

@mtrofin mtrofin changed the title Updated Pipfile.lock Pipfile.lock specific to the python version Dec 17, 2025
Copy link
Collaborator

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a big fan of a python wrapper around pipenv, and would probably prefer we just add directions to manually copy the pipfile, but I guess this works for now.

@mtrofin
Copy link
Collaborator Author

mtrofin commented Dec 17, 2025

I'm not a big fan of a python wrapper around pipenv, and would probably prefer we just add directions to manually copy the pipfile, but I guess this works for now.

Or maybe we switch to another similar mechanism that supports this scenario (if it exists)?

@mtrofin mtrofin merged commit 8220c3e into google:main Dec 17, 2025
12 checks passed
@mtrofin mtrofin deleted the lock branch December 17, 2025 05:45
mtrofin added a commit that referenced this pull request Dec 17, 2025
After #535, it's easier to just clone the repo to install the dependencies.
mtrofin added a commit that referenced this pull request Dec 17, 2025
After #535, it's easier to just clone the repo to install the
dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants