feat: make options for appendAnimation and detachAnimation optional#5025
Open
Frank3K wants to merge 1 commit intogoogle:masterfrom
Open
feat: make options for appendAnimation and detachAnimation optional#5025Frank3K wants to merge 1 commit intogoogle:masterfrom
Frank3K wants to merge 1 commit intogoogle:masterfrom
Conversation
Such that the following is possible:
// Example: Only specify repetitions
appendAnimation('some-animation', { repetitions: 5 });
// Example: Only specify fade for detach
detachAnimation('some-animation', { fade: 200 });
Frank3K
commented
Apr 15, 2025
| LoopPingPong : | ||
| (repetitions === 1 ? LoopOnce : LoopRepeat); | ||
|
|
||
| const needsToStop = repetitions !== Infinity || mode !== LoopPingPong; |
Contributor
Author
There was a problem hiding this comment.
@mohammadbaghaei I am particularly not 100% sure about this line.
Collaborator
|
Thanks for requesting these changes, I'll need to test them before submitting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes all parameters of
AppendAnimationOptionsandDetachAnimationOptionsoptional.Such that the following is possible:
Previously, you had to pass all options, or no options at all (in case the default was used). Current code in
master:model-viewer/packages/model-viewer/src/features/animation.ts
Lines 33 to 41 in 4efaf8e
@mohammadbaghaei Would you be so kind to do the review? I tried to use appendAnimation, but then I was a bit surprised I needed to pass all parameters. I have no real experience with these methods, so it would be nice if you can take a look and functionally test.
Reference Issue