Skip to content

Comments

feat: ctrl+right click always pins the new selection instead of toggling the pinned state#826

Open
seankmartin wants to merge 4 commits intogoogle:masterfrom
MetaCell:feat/always-pin-selection
Open

feat: ctrl+right click always pins the new selection instead of toggling the pinned state#826
seankmartin wants to merge 4 commits intogoogle:masterfrom
MetaCell:feat/always-pin-selection

Conversation

@seankmartin
Copy link
Contributor

See #814 I think this enables the intended behaviour there if I'm understanding correctly. I've also been a little confused in the past when trying to pin a new segment but actually just unpinning my current segment. It does mean you have to manually unpin now from what I can tell though. Anyway open to thoughts from @unidesigner @jbms

unidesigner added a commit to BrainCircuitsIO/neuroglancer-demo that referenced this pull request Aug 21, 2025
@seankmartin
Copy link
Contributor Author

I'll close this for now, could be reopened if a different mechanism to unpin is found

@seankmartin seankmartin closed this Oct 3, 2025
@seankmartin seankmartin reopened this Feb 20, 2026
@seankmartin
Copy link
Contributor Author

Reopening as have implemented the suggestion of @chrisj and @jbms in #814 to create a new action for unpinning. I know there was a suggested change to the hover mode discussed there as well but I don't think that would block this? And could be a later addition? Please correct me if I have that wrong @chrisj @fcollman

@seankmartin seankmartin marked this pull request as ready for review February 20, 2026 16:44
@fcollman
Copy link
Contributor

I think this works well ... i would add some notes to the hover on pin to indicate this..

when pinned, tooltip shows
unpin
ctrl+shift+rightclick to select on hover

when unpinned, tooltip shows
pin
ctrl+rightclick to select and pin

@fcollman
Copy link
Contributor

I think this is a relatively simple PR code wise and functionality I think is an improvement. I'd give it a thumbs up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants