feat: ctrl+right click always pins the new selection instead of toggling the pinned state#826
feat: ctrl+right click always pins the new selection instead of toggling the pinned state#826seankmartin wants to merge 4 commits intogoogle:masterfrom
Conversation
|
I'll close this for now, could be reopened if a different mechanism to unpin is found |
|
Reopening as have implemented the suggestion of @chrisj and @jbms in #814 to create a new action for unpinning. I know there was a suggested change to the hover mode discussed there as well but I don't think that would block this? And could be a later addition? Please correct me if I have that wrong @chrisj @fcollman |
|
I think this works well ... i would add some notes to the hover on pin to indicate this.. when pinned, tooltip shows when unpinned, tooltip shows |
|
I think this is a relatively simple PR code wise and functionality I think is an improvement. I'd give it a thumbs up. |
See #814 I think this enables the intended behaviour there if I'm understanding correctly. I've also been a little confused in the past when trying to pin a new segment but actually just unpinning my current segment. It does mean you have to manually unpin now from what I can tell though. Anyway open to thoughts from @unidesigner @jbms