feat(skeleton): skeleton line width control and conversion from model units#878
Open
chrisj wants to merge 5 commits intogoogle:masterfrom
Open
feat(skeleton): skeleton line width control and conversion from model units#878chrisj wants to merge 5 commits intogoogle:masterfrom
chrisj wants to merge 5 commits intogoogle:masterfrom
Conversation
…ls. Migrated skeleton shader editor to control vertex shader instead of fragment shader (match behavior of annotation layer).
…n indicates radius is in "stored model" units
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuing from: #820
Based on this section from the skeleton documentation:
I've renamed the shader function to "modelToPixels"
The documentation also indicates:
So I think it is fine to keep the calculation of the scaling factor to be based on just a single dimension. What is lacking is the ability to use the display dimension scale. I think a 3d approach to rendering skeletons is the right choice if that matters.
I will look into finding a way to add good tests for this feature
I left in the line annotation code so we can see what adding annotation support would look like, but I will strip that out of this PR