Conversation
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman reviewed 28 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ptkach).
gbrodman
left a comment
There was a problem hiding this comment.
can't tell what changed in the screenshots when looking at them in github, which means it lgtm
@gbrodman reviewed 19 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ptkach).
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman reviewed 8 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ptkach).
console-webapp/dev-proxy.config.json line 4 at r3 (raw file):
"/console-api": { "target": "http://[::1]:8080",
did you test this change with the local dev server? i remember this being finicky before
console-webapp/src/app/settings/security/security.component.spec.ts line 61 at r3 (raw file):
}).compileComponents(); // Update your saveSpy reference
what's this comment?
ptkach
left a comment
There was a problem hiding this comment.
Yeah new version of angular material, so might be some minor colors, borders, spacings differences here and there
@ptkach made 3 comments.
Reviewable status: 52 of 53 files reviewed, 2 unresolved discussions (waiting on gbrodman).
console-webapp/dev-proxy.config.json line 4 at r3 (raw file):
Previously, gbrodman wrote…
did you test this change with the local dev server? i remember this being finicky before
Yeah it actually stopped working after update, so this is what fixed it
console-webapp/src/app/settings/security/security.component.spec.ts line 61 at r3 (raw file):
Previously, gbrodman wrote…
what's this comment?
Removed, documentation copy-paste
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman reviewed 1 file and all commit messages, and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ptkach).
Tested on alpha
This change is