Skip to content

[bazel][NFC] Inline and simplify platform selection #4770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gchatelet merged 1 commit into from
Sep 4, 2025
Merged

[bazel][NFC] Inline and simplify platform selection #4770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions ortools/algorithms/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,6 @@ package(default_visibility = ["//visibility:public"])
# Description:
# Home of algorithms used in OR solvers

config_setting(
name = "on_linux",
constraint_values = ["@platforms//os:linux"],
)

config_setting(
name = "on_macos",
constraint_values = ["@platforms//os:macos"],
)

config_setting(
name = "on_windows",
constraint_values = ["@platforms//os:windows"],
)

# OSS solvers
bool_flag(
name = "with_cbc",
Expand Down Expand Up @@ -110,9 +95,7 @@ cc_test(
name = "radix_sort_test",
srcs = ["radix_sort_test.cc"],
copts = select({
"on_linux": [],
"on_macos": [],
"on_windows": ["/Zc:preprocessor"],
"@platforms//os:windows": ["/Zc:preprocessor"],
"//conditions:default": [],
}),
deps = [
Expand Down
27 changes: 3 additions & 24 deletions ortools/base/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,6 @@ load("@rules_cc//cc:cc_test.bzl", "cc_test")

package(default_visibility = ["//visibility:public"])

config_setting(
name = "on_linux",
constraint_values = ["@platforms//os:linux"],
)

config_setting(
name = "on_macos",
constraint_values = ["@platforms//os:macos"],
)

config_setting(
name = "on_windows",
constraint_values = ["@platforms//os:windows"],
)

filegroup(
name = "base_swig",
srcs = [
Expand Down Expand Up @@ -82,9 +67,7 @@ cc_library(
"-DOR_TOOLS_PATCH=9999",
],
linkopts = select({
"on_linux": [],
"on_macos": ["-framework CoreFoundation"],
"on_windows": [],
"@platforms//os:macos": ["-framework CoreFoundation"],
"//conditions:default": [],
}),
deps = [
Expand Down Expand Up @@ -180,9 +163,7 @@ cc_library(
name = "dump_vars",
hdrs = ["dump_vars.h"],
copts = select({
"on_linux": [],
"on_macos": [],
"on_windows": ["/Zc:preprocessor"],
"@platforms//os:windows": ["/Zc:preprocessor"],
"//conditions:default": [],
}),
deps = [
Expand All @@ -197,9 +178,7 @@ cc_test(
size = "small",
srcs = ["dump_vars_test.cc"],
copts = select({
"on_linux": [],
"on_macos": [],
"on_windows": ["/Zc:preprocessor"],
"@platforms//os:windows": ["/Zc:preprocessor"],
"//conditions:default": [],
}),
deps = [
Expand Down
15 changes: 0 additions & 15 deletions ortools/constraint_solver/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,6 @@ load("@protobuf//bazel:py_proto_library.bzl", "py_proto_library")
load("@rules_cc//cc:cc_library.bzl", "cc_library")
load("@rules_python//python:py_library.bzl", "py_library")

config_setting(
name = "on_linux",
constraint_values = ["@platforms//os:linux"],
)

config_setting(
name = "on_macos",
constraint_values = ["@platforms//os:macos"],
)

config_setting(
name = "on_windows",
constraint_values = ["@platforms//os:windows"],
)

proto_library(
name = "assignment_proto",
srcs = ["assignment.proto"],
Expand Down
26 changes: 2 additions & 24 deletions ortools/flatzinc/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,27 +20,6 @@ load("@rules_cc//cc:cc_library.bzl", "cc_library")

package(default_visibility = ["//visibility:public"])

config_setting(
name = "on_linux",
constraint_values = [
"@platforms//os:linux",
],
)

config_setting(
name = "on_macos",
constraint_values = [
"@platforms//os:macos",
],
)

config_setting(
name = "on_windows",
constraint_values = [
"@platforms//os:windows",
],
)

# ---------------------------------------------------------------------------
# Baseline flatzinc model.
# ---------------------------------------------------------------------------
Expand Down Expand Up @@ -88,9 +67,8 @@ cc_library(
name = "parser_lex_lib",
srcs = ["parser.yy.cc"],
copts = select({
"on_linux": ["-Wno-unused-function"], # parser.yy.cc
"on_macos": ["-Wno-unused-function"], # parser.yy.cc
"on_windows": [],
"@platforms//os:linux": ["-Wno-unused-function"], # parser.yy.cc
"@platforms//os:macos": ["-Wno-unused-function"], # parser.yy.cc
"//conditions:default": [],
}),
deps = [
Expand Down
27 changes: 3 additions & 24 deletions ortools/glop/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,34 +20,13 @@ package(
default_visibility = ["//visibility:public"],
)

config_setting(
name = "on_linux",
constraint_values = [
"@platforms//os:linux",
],
)

config_setting(
name = "on_macos",
constraint_values = [
"@platforms//os:macos",
],
)

config_setting(
name = "on_windows",
constraint_values = [
"@platforms//os:windows",
],
)

# Floating-point code in this directory must not be compiled with
# dangerous optimizations. For example do not assume that FP expressions
# are associative. This is what -fno-fast-math is for.
SAFE_FP_CODE = select({
"on_linux": ["-fno-fast-math"],
"on_macos": [], # no_fast_math is the default.
"on_windows": [], # /fp:precise is the default.
"@platforms//os:linux": ["-fno-fast-math"],
"@platforms//os:macos": [], # no_fast_math is the default.
"@platforms//os:windows": [], # /fp:precise is the default.
"//conditions:default": [],
})

Expand Down
19 changes: 1 addition & 18 deletions ortools/graph/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,6 @@ load("@rules_cc//cc:cc_binary.bzl", "cc_binary")
load("@rules_cc//cc:cc_library.bzl", "cc_library")
load("@rules_cc//cc:cc_test.bzl", "cc_test")

config_setting(
name = "on_linux",
constraint_values = ["@platforms//os:linux"],
)

config_setting(
name = "on_macos",
constraint_values = ["@platforms//os:macos"],
)

config_setting(
name = "on_windows",
constraint_values = ["@platforms//os:windows"],
)

cc_library(
name = "graph",
hdrs = ["graph.h"],
Expand Down Expand Up @@ -533,9 +518,7 @@ cc_library(
srcs = ["min_cost_flow.cc"],
hdrs = ["min_cost_flow.h"],
copts = select({
"on_linux": [],
"on_macos": [],
"on_windows": ["/Zc:preprocessor"],
"@platforms//os:windows": ["/Zc:preprocessor"],
"//conditions:default": [],
}),
visibility = ["//visibility:public"],
Expand Down
27 changes: 3 additions & 24 deletions ortools/lp_data/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,34 +15,13 @@ load("@rules_cc//cc:cc_library.bzl", "cc_library")

package(default_visibility = ["//visibility:public"])

config_setting(
name = "on_linux",
constraint_values = [
"@platforms//os:linux",
],
)

config_setting(
name = "on_macos",
constraint_values = [
"@platforms//os:macos",
],
)

config_setting(
name = "on_windows",
constraint_values = [
"@platforms//os:windows",
],
)

# Floating-point code in this directory must not be compiled with
# dangerous optimizations. For example do not assume that FP expressions
# are associative. This is what -fno-fast-math is for.
SAFE_FP_CODE = select({
"on_linux": ["-fno-fast-math"],
"on_macos": [], # no_fast_math is the default.
"on_windows": [], # /fp:precise is the default.
"@platforms//os:linux": ["-fno-fast-math"],
"@platforms//os:macos": [], # no_fast_math is the default.
"@platforms//os:windows": [], # /fp:precise is the default.
"//conditions:default": [],
})

Expand Down
19 changes: 1 addition & 18 deletions ortools/routing/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,21 +19,6 @@ load("@rules_cc//cc:cc_library.bzl", "cc_library")

package(default_visibility = ["//visibility:public"])

config_setting(
name = "on_linux",
constraint_values = ["@platforms//os:linux"],
)

config_setting(
name = "on_macos",
constraint_values = ["@platforms//os:macos"],
)

config_setting(
name = "on_windows",
constraint_values = ["@platforms//os:windows"],
)

proto_library(
name = "enums_proto",
srcs = ["enums.proto"],
Expand Down Expand Up @@ -236,9 +221,7 @@ cc_library(
"search.h",
],
copts = select({
"on_linux": [],
"on_macos": [],
"on_windows": ["/Zc:preprocessor"],
"@platforms//os:windows": ["/Zc:preprocessor"],
"//conditions:default": [],
}),
deps = [
Expand Down
19 changes: 1 addition & 18 deletions ortools/third_party_solvers/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,28 +15,11 @@ load("@rules_cc//cc:cc_library.bzl", "cc_library")

package(default_visibility = ["//visibility:public"])

config_setting(
name = "on_linux",
constraint_values = ["@platforms//os:linux"],
)

config_setting(
name = "on_macos",
constraint_values = ["@platforms//os:macos"],
)

config_setting(
name = "on_windows",
constraint_values = ["@platforms//os:windows"],
)

cc_library(
name = "dynamic_library",
hdrs = ["dynamic_library.h"],
linkopts = select({
"on_linux": ["-Wl,--no-as-needed -ldl"],
"on_macos": [],
"on_windows": [],
"@platforms//os:linux": ["-Wl,--no-as-needed -ldl"],
"//conditions:default": [],
}),
deps = [
Expand Down
31 changes: 4 additions & 27 deletions ortools/util/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,27 +18,6 @@ load("@rules_cc//cc:cc_library.bzl", "cc_library")

package(default_visibility = ["//visibility:public"])

config_setting(
name = "on_linux",
constraint_values = [
"@platforms//os:linux",
],
)

config_setting(
name = "on_macos",
constraint_values = [
"@platforms//os:macos",
],
)

config_setting(
name = "on_windows",
constraint_values = [
"@platforms//os:windows",
],
)

# OptionalBoolean
proto_library(
name = "optional_boolean_proto",
Expand Down Expand Up @@ -132,9 +111,7 @@ cc_library(
srcs = ["piecewise_linear_function.cc"],
hdrs = ["piecewise_linear_function.h"],
copts = select({
"on_linux": [],
"on_macos": [],
"on_windows": ["/Zc:preprocessor"],
"@platforms//os:windows": ["/Zc:preprocessor"],
"//conditions:default": [],
}),
deps = [
Expand Down Expand Up @@ -244,9 +221,9 @@ cc_library(
# You must also set this flag if you depend on this target and use
# its methods related to IEEE-754 rounding modes.
copts = select({
"on_linux": ["-frounding-math"],
"on_macos": ["-frounding-math"],
"on_windows": [],
"@platforms//os:linux": ["-frounding-math"],
"@platforms//os:macos": ["-frounding-math"],
"@platforms//os:windows": [],
"//conditions:default": ["-frounding-math"],
}),
deps = [
Expand Down
Loading
Loading