cmake: system_deps build googletest #4908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
have to built it to have string_view support
Collaborator
Author
|
this PR fix compilation errors, but we still have some issue at runtime since archlinux already use/provide Protobuf v33.0 while |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: have to built it to have string_view support
long story: currently you can built googletest with or without abseil-cpp, BUT if you built it without (like most distro do) then you won't have
std::string_view(usingabsl::string_viewalias) support in all googletest API...in google3 we do use use absl::string_view with googletest so it is mandatory to have absl support in googletest when exporting or-tools tests...