-
Notifications
You must be signed in to change notification settings - Fork 2.5k
infra: bump to llvm 22 #13915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: bump to llvm 22 #13915
Conversation
@@ -60,14 +60,15 @@ apt-get update && apt-get install -y $LLVM_DEP_PACKAGES --no-install-recommends | |||
# languages, projects, ...) is needed. | |||
# Check CMAKE_VERSION infra/base-images/base-clang/Dockerfile was released | |||
# recently enough to fully support this clang version. | |||
OUR_LLVM_REVISION=llvmorg-18.1.8 | |||
OUR_LLVM_REVISION=llvmorg-21.1.0-rc3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think RUSTUP_TOOLCHAIN
should be bumped as well to avoid coverage build failures due to raw profile version mismatches. There are projects where RUSTUP_TOOLCHAIN
was already bumped separately (for example 5a93222) and where coverage builds fail because of that but the other projects probably expect llvm to be in sync with rustc shipped in the base-builder images.
Ref: #13915 --------- Signed-off-by: David Korczynski <[email protected]>
Addressing projects that have errors like the following: ```sh Step #23 - "compile-libfuzzer-address-x86_64": �[1m/usr/local/lib/clang/21/include/fuzzer/FuzzedDataProvider.h:206:22: �[0m�[0;1;31merror: �[0m�[1mno template named 'is_integral_v' in namespace 'std'; did you mean 'is_integral'?�[0m Step #23 - "compile-libfuzzer-address-x86_64": 206 | �[0;34mstatic_assert�[0m(std::is_integral_v<T>, �[0;32m"An integral type is required."�[0m);�[0m Step #23 - "compile-libfuzzer-address-x86_64": | �[0;1;32m ~~~~~^ Step #23 - "compile-libfuzzer-address-x86_64": �[0m�[1m/usr/local/bin/../include/c++/v1/__type_traits/is_integral.h:25:35: �[0m�[0;1;36mnote: �[0m'is_integral' declared here�[0m Step #23 - "compile-libfuzzer-address-x86_64": 25 | �[0;34mstruct�[0m _LIBCPP_NO_SPECIALIZATIONS is_integral : _BoolConstant<�[0;34m__is_integral�[0m(_Tp)> {};�[0m Step #23 - "compile-libfuzzer-address-x86_64": | �[0;1;32m ^ Step #23 - "compile-libfuzzer-address-x86_64": �[0mIn file included from /src/buffer_fuzzer.cc:19: Step #23 - "compile-libfuzzer-address-x86_64": �[1m/usr/local/lib/clang/21/include/fuzzer/FuzzedDataProvider.h:206:38: �[0m�[0;1;31merror: �[0m�[1mexpected '(' for function-style cast or type construction�[0m Step #23 - "compile-libfuzzer-address-x86_64": 206 | �[0;34mstatic_assert�[0m(std::is_integral_v<T>, �[0;32m"An integral type is required."�[0m);�[0m Step #23 - "compile-libfuzzer-address-x86_64": | �[0;1;32m ~~~~~~~~~~~~~~~~~~~~~^ Step #23 - "compile-libfuzzer-address-x86_64": �[0m�[1m/usr/local/lib/clang/21/include/fuzzer/FuzzedDataProvider.h:274:22: �[0m�[0;1;31merror: �[0m�[1mno template named 'is_floating_point_v' in namespace 'std'; did you mean 'is_floating_point'?�[0m Step #23 - "compile-libfuzzer-address-x86_64": 274 | �[0;34mstatic_assert�[0m(std::is_floating_point_v<T>,�[0m ``` From #13848 (comment) Ref #13915 --------- Signed-off-by: David Korczynski <[email protected]>
/gcbrun trial_build.py all --fuzzing-engines libfuzzer --sanitizers address |
1 similar comment
/gcbrun trial_build.py all --fuzzing-engines libfuzzer --sanitizers address |
d2c408e
to
5146ad4
Compare
/gcbrun trial_build.py all --fuzzing-engines libfuzzer --sanitizers address |
|
ref: #13915 --------- Signed-off-by: David Korczynski <[email protected]>
ref: #13915 Signed-off-by: David Korczynski <[email protected]>
Ref: #13915 --------- Signed-off-by: David Korczynski <[email protected]>
Ref: #13915 --------- Signed-off-by: David Korczynski <[email protected]>
5146ad4
to
b8b40bf
Compare
/gcbrun trial_build.py all --fuzzing-engines libfuzzer --sanitizers address |
Failed projects: Step #1: INFO:root:Failed project, Statuses, Logs
Step #1: INFO:root:firestore, FAILURE, https://oss-fuzz-gcb-logs.storage.googleapis.com/log-caebf653-ca81-4c38-9923-a5fd4e5e8058.txt
Step #1: INFO:root:grpc-httpjson-transcoding, FAILURE, https://oss-fuzz-gcb-logs.storage.googleapis.com/log-95ff7164-9db3-48c2-b2dd-2d499e15bca8.txt
Step #1: INFO:root:karchive, FAILURE, https://oss-fuzz-gcb-logs.storage.googleapis.com/log-40660d4b-90f9-4eba-a209-be9f9ff7d35c.txt
Step #1: INFO:root:kcodecs, FAILURE, https://oss-fuzz-gcb-logs.storage.googleapis.com/log-fe9f64df-f298-46c8-87a2-19c42a0d60c5.txt
Step #1: INFO:root:kimageformats, FAILURE, https://oss-fuzz-gcb-logs.storage.googleapis.com/log-d570963c-5fa4-40c8-9fd4-0619e4c9364d.txt
Step #1: INFO:root:kmime, FAILURE, https://oss-fuzz-gcb-logs.storage.googleapis.com/log-2427e1a9-a445-4e72-a0fd-560e4fea0a34.txt
Step #1: INFO:root:libphonenumber, FAILURE, https://oss-fuzz-gcb-logs.storage.googleapis.com/log-1d0ac102-0215-456e-bdde-eb60e8e01c37.txt
Step #1: INFO:root:lxc, FAILURE, https://oss-fuzz-gcb-logs.storage.googleapis.com/log-9a8ee718-27e8-4438-b551-b0d96d5e1ca4.txt
Step #1: INFO:root:nodejs, FAILURE, https://oss-fuzz-gcb-logs.storage.googleapis.com/log-6d83b7d6-aed5-48f0-a34f-04a70b60f034.txt
Step #1: INFO:root:nss, FAILURE, https://oss-fuzz-gcb-logs.storage.googleapis.com/log-2c86646d-f13e-44e2-aa65-cc5f4d186b46.txt
Step #1: INFO:root:openbabel, FAILURE, https://oss-fuzz-gcb-logs.storage.googleapis.com/log-d684fb53-9108-40e1-84ca-4a92b827a5c8.txt
Step #1: INFO:root:osquery, FAILURE, https://oss-fuzz-gcb-logs.storage.googleapis.com/log-fe7bbf23-f510-4a94-bf3b-467776cae6c7.txt
Step #1: INFO:root:php, FAILURE, https://oss-fuzz-gcb-logs.storage.googleapis.com/log-c416b324-b59f-43d9-ba16-8ec044a52cc6.txt
Step #1: INFO:root:qt, FAILURE, https://oss-fuzz-gcb-logs.storage.googleapis.com/log-d05f39de-1643-49da-9db8-f74283450745.txt
Step #1: INFO:root:rtpproxy, FAILURE, https://oss-fuzz-gcb-logs.storage.googleapis.com/log-4aa76d95-14a9-45a6-ad46-d2ec2d90f657.txt
Step #1: INFO:root:wasmedge, FAILURE, https://oss-fuzz-gcb-logs.storage.googleapis.com/log-7fd8a80f-66e7-4ac2-a28e-1e769169645e.txt
Step #1: INFO:root:angle, FAILURE, https://oss-fuzz-gcb-logs.storage.googleapis.com/log-d0eca84c-d072-4b08-a604-db1ec4eb83c8.txt
Step #1: INFO:root:monero, FAILURE, https://oss-fuzz-gcb-logs.storage.googleapis.com/log-e047c450-5bad-4d31-a681-e0142b8d3815.txt |
ref: #13915 (comment) Signed-off-by: David Korczynski <[email protected]>
Ref: #13915 (comment) Signed-off-by: David Korczynski <[email protected]>
Ref: #13915 (comment) Signed-off-by: David Korczynski <[email protected]>
ref: #13915 (comment) Signed-off-by: David Korczynski <[email protected]>
28e2d2b
to
0c4509c
Compare
/gcbrun trial_build.py all --fuzzing-engines libfuzzer --sanitizers address |
|
Updates LLVM usage to match [cb2f0d0a5f14](llvm/llvm-project@cb2f0d0a5f14) Indexer-PiperOrigin-RevId: 802610159
This has now been adjusted to bump for LLVM 22 due to 23c943f |
d3127f8
to
2a84900
Compare
/gcbrun trial_build.py all --fuzzing-engines libfuzzer --sanitizers address |
|
7cda748
to
ba25f4d
Compare
2371e92
to
ece92fe
Compare
Signed-off-by: David Korczynski <[email protected]>
ece92fe
to
dd63f3d
Compare
/gcbrun trial_build.py all --fuzzing-engines libfuzzer --sanitizers address |
kimageformats: will be fixed by pinning in #13951 There are a few projects that need follow up but it should be straightforward. I don't think it's necessary to run more trial builds for this. I'd say this is good to go. |
Follow up to #13901 and #13848
This proposes a clean llvm upgrade, so without having different llvm versions in base-clang and base-clang-full.
Continuing from issues in #13848 (comment)