feat(ci): Add public log URLs to build failure reports #14154

hunsche · 2025-10-19T17:37:50Z

This PR improves the trial build process by providing direct, public links to raw log files in the failure reports. When a build fails during either Phase 1 (base image creation) or Phase 2 (project compilation), the summary report will now include a Log URL that points directly to the log-{build_id}.txt file in the public GCS bucket.

Motivation

Project maintainers without direct GCP access often have difficulty viewing detailed logs for build failures in their pull requests. This issue was highlighted after commit 4b541c7c removed the immediate logging of build URLs upon job creation.

This change restores and enhances log visibility in a clean, accessible way, allowing maintainers to quickly diagnose and fix build issues without needing special permissions.

Changes Made

trial_build.py: Modified to construct and display the public log URL for any failed Phase 2 project build.
build_and_push_test_images.py: Modified to display the public log URL for a failed Phase 1 base image build.

Adds a direct link to the public GCS log file in the failure summary for both Phase 1 (base image) and Phase 2 (project) builds. This provides immediate and easy access to raw build logs for project maintainers, who do not have access to the GCP console, improving the debugging workflow for trial builds.

hunsche · 2025-10-19T17:43:48Z

/gcbrun trial_build.py zlib --sanitizer introspector --fuzzing-engine libfuzzer

hunsche · 2025-10-19T19:17:05Z

/gcbrun trial_build.py zlib --sanitizer introspector --fuzzing-engine libfuzzer --force-build

hunsche · 2025-10-19T19:51:03Z

/gcbrun trial_build.py zlib --sanitizer introspector --fuzzing-engine libfuzzer --force-build

hunsche · 2025-10-19T21:31:51Z

/gcbrun trial_build.py zlib --sanitizer introspector --fuzzing-engine libfuzzer --force-build

oliverchang · 2025-10-20T05:08:13Z

infra/build/functions/build_and_push_test_images.py

      '----------------------------------------------------------------')
  logging.info('GCB Build ID: %s', build_id)
  logging.info('GCB Build URL: %s', logs_url)
+  log_url = (f'https://oss-fuzz-gcb-logs.storage.googleapis.com/'


this is repeated many times in this PR. Can you create a common helper in build_lib for this and use that everywhere?

Done. I've moved the repeated logging into a common helper function.

hunsche · 2025-10-20T13:12:39Z

/gcbrun trial_build.py zlib --sanitizer introspector --fuzzing-engine libfuzzer --force-build

Created a new helper function `get_build_info_lines` in `build_lib.py` to generate formatted build information (ID, GCB URL, Log URL). This centralizes the logic and removes code duplication. All call sites in `trial_build.py` and `build_and_push_test_images.py` have been updated to use this new function, preserving the original indentation and formatting at each location.

hunsche · 2025-10-20T13:13:50Z

/gcbrun trial_build.py zlib --sanitizer introspector --fuzzing-engine libfuzzer --force-build

Increased the base backoff time to 5 seconds to reduce the frequency of retries. Removed the warning log for each retry attempt and added a final error log that only triggers when the maximum number of retries is exhausted. This makes the logs cleaner in case of transient API failures.

hunsche · 2025-10-20T13:40:29Z

/gcbrun trial_build.py zlib --sanitizer introspector --fuzzing-engine libfuzzer --force-build

The previous implementation assumed that the `run_build` function would always return a dictionary containing an 'id' key. However, in cases where the build fails to start, it could return a different value, causing a `TypeError: string indices must be integers`. This change adds a check to validate the response from `run_build` before accessing the 'id'. If the response is not the expected dictionary, it logs the complete error, providing better diagnostics for build startup failures.

hunsche · 2025-10-20T14:41:33Z

/gcbrun trial_build.py zlib --sanitizer introspector --fuzzing-engine libfuzzer --force-build

hunsche · 2025-10-20T14:44:46Z

/gcbrun trial_build.py zlib --sanitizer introspector --fuzzing-engine libfuzzer --force-build

…ction

…ilds function

hunsche · 2025-10-20T17:11:45Z

/gcbrun trial_build.py zlib --sanitizer introspector --fuzzing-engine libfuzzer --force-build

hunsche · 2025-10-20T20:03:31Z

/gcbrun skip

hunsche · 2025-10-20T20:06:26Z

/gcbrun skip

hunsche · 2025-10-20T20:19:17Z

/gcbrun skip

hunsche · 2025-10-20T20:25:06Z

/gcbrun trial_build.py zlib --sanitizer introspector --fuzzing-engine libfuzzer --force-build

hunsche · 2025-10-20T21:13:12Z

/gcbrun skip

hunsche · 2025-10-20T21:14:17Z

/gcbrun trial_build.py zlib --sanitizer introspector --fuzzing-engine libfuzzer --force-build

oliverchang · 2025-10-20T23:00:51Z

infra/build/functions/report_generator.py


 def main():
  """Main function to generate report and determine pipeline status."""
+  comment = os.environ.get('_COMMENT_BODY')


what sets _COMMENT_BODY ?

I cannot find a reference to it anywhere.

My mistake, I thought this was a valid substitution variable. I've refactored the logic to use a simple flag instead, which is more robust and works.

oliverchang · 2025-10-20T23:03:28Z

infra/build/functions/trial_build.py

-          logs_url = build_lib.get_gcb_url(build_id, cloud_project)
-          failed_builds[project].append((status, logs_url, build_type))
+          gcb_url = build_lib.get_gcb_url(build_id, cloud_project)
+          log_url = (f'https://oss-fuzz-gcb-logs.storage.googleapis.com/'


get_logs_url ?

oliverchang · 2025-10-20T23:03:33Z

infra/build/functions/trial_build.py

      for build_id, build_type in project_builds:
-        logs_url = build_lib.get_gcb_url(build_id, cloud_project)
+        gcb_url = build_lib.get_gcb_url(build_id, cloud_project)
+        log_url = (f'https://oss-fuzz-gcb-logs.storage.googleapis.com/'


get_logs_url ?

- In gcb.py, create a 'build_skipped.flag' in /workspace if no /gcbrun command is found. - In report_generator.py, check for this flag and exit gracefully if it exists. This prevents CI failures on pull requests where a trial build was not requested. - In trial_build.py, refactor log URL generation to use the centralized build_lib.get_logs_url function.

hunsche · 2025-10-20T23:48:27Z

/gcbrun trial_build.py zlib --sanitizer introspector --fuzzing-engine libfuzzer --force-build

Change flag file path to be relative for CI test compatibility. Rename flag to trial_build_skipped.flag for clarity.

hunsche · 2025-10-21T00:34:30Z

/gcbrun skip

hunsche · 2025-10-21T00:35:44Z

/gcbrun trial_build.py zlib --sanitizer introspector --fuzzing-engine libfuzzer --force-build

Fixes a regression that caused malformed GCS URLs for corpus downloads. The logic was incorrectly stripping the leading slash from the GCS path, resulting in a double slash ("//") in the final signed URL. This caused downloads to fail silently, leading to invalid corpus zip files and subsequent `unzip` failures in the coverage builds. This change restores the correct URL parsing logic.

hunsche · 2025-10-21T01:36:48Z

/gcbrun trial_build.py zlib --sanitizer introspector --fuzzing-engine libfuzzer --force-build

Fixes a regression that caused malformed GCS URLs for corpus downloads. The logic was incorrectly stripping the leading slash from the GCS path, resulting in a double slash ("//") in the final signed URL. This caused downloads to fail silently, leading to invalid corpus zip files and subsequent `unzip` failures in the coverage builds. This change restores the correct URL parsing logic.

hunsche · 2025-10-21T01:44:22Z

/gcbrun trial_build.py zlib --sanitizer introspector --fuzzing-engine libfuzzer --force-build

hunsche · 2025-10-21T01:47:36Z

/gcbrun skip

hunsche requested a review from DavidKorczynski October 19, 2025 17:37

fix(ci): Explicitly set logsBucket for dynamic builds

83de133

fix(ci): Add log URL to initial Phase 1 report

2449f3c

fix(ci): Add log URL to initial Phase 2 report

04b5b46

hunsche requested a review from vitaliset October 19, 2025 21:53

hunsche enabled auto-merge (squash) October 19, 2025 21:54

hunsche requested a review from oliverchang October 19, 2025 22:35

oliverchang requested changes Oct 20, 2025

View reviewed changes

hunsche and others added 3 commits October 20, 2025 10:12

Merge branch 'master' into feat/add-public-log-urls

4e97b32

feat: Handle trial builds with no reports

0809195

hunsche requested a review from oliverchang October 20, 2025 13:14

style: Apply yapf formatting

42c456f

hunsche and others added 3 commits October 20, 2025 14:04

Merge branch 'master' into feat/add-public-log-urls

a1af255

refactor: Simplify build result handling in _do_build_type_builds fun…

04dad19

…ction

style: Adjust indentation for better readability in _do_build_type_bu…

8bd3e3d

…ilds function

Merge branch 'master' into feat/add-public-log-urls

614f62a

hunsche added 2 commits October 20, 2025 19:57

feat(build): Skip report_generator when not invoked explicitly

7696bc8

Style: Remove comments and apply formatting

02d49bd

Fix: Add missing logging import in report_generator

605c7e3

hunsche force-pushed the feat/add-public-log-urls branch from 883b75b to 605c7e3 Compare October 20, 2025 20:06

Fix: Flush output buffer to ensure skip message is logged

26a982e

Fix: Pass project_name to run_build in trial_build

36f2912

hunsche added 2 commits October 20, 2025 21:11

Refactor: Remove logging and unused code in trial_build_main function

2cea774

Fix: Simplify print statement in main function for clarity

aba1f11

oliverchang reviewed Oct 20, 2025

View reviewed changes

hunsche requested a review from oliverchang October 20, 2025 23:48

fix: Correct flag file path and name for CI tests

0953c7d

Change flag file path to be relative for CI test compatibility. Rename flag to trial_build_skipped.flag for clarity.

hunsche and others added 2 commits October 21, 2025 01:42

Merge branch 'master' into feat/add-public-log-urls

582bef4

oliverchang approved these changes Oct 21, 2025

View reviewed changes

hunsche merged commit 1242ccb into master Oct 21, 2025
19 checks passed

hunsche deleted the feat/add-public-log-urls branch October 21, 2025 02:33

feat(ci): Add public log URLs to build failure reports #14154

feat(ci): Add public log URLs to build failure reports #14154

Conversation

hunsche commented Oct 19, 2025

Motivation

Changes Made

Uh oh!

hunsche commented Oct 19, 2025

Uh oh!

hunsche commented Oct 19, 2025

Uh oh!

hunsche commented Oct 19, 2025

Uh oh!

hunsche commented Oct 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hunsche commented Oct 20, 2025

Uh oh!

hunsche commented Oct 20, 2025

Uh oh!

hunsche commented Oct 20, 2025

Uh oh!

hunsche commented Oct 20, 2025

Uh oh!

hunsche commented Oct 20, 2025

Uh oh!

hunsche commented Oct 20, 2025

Uh oh!

hunsche commented Oct 20, 2025

Uh oh!

hunsche commented Oct 20, 2025

Uh oh!

hunsche commented Oct 20, 2025

Uh oh!

hunsche commented Oct 20, 2025

Uh oh!

hunsche commented Oct 20, 2025

Uh oh!

hunsche commented Oct 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hunsche commented Oct 20, 2025

Uh oh!

hunsche commented Oct 21, 2025

Uh oh!

hunsche commented Oct 21, 2025

Uh oh!

hunsche commented Oct 21, 2025

Uh oh!

hunsche commented Oct 21, 2025

Uh oh!

hunsche commented Oct 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants