urllib3: Fix fuzz_requests#14742
Merged
DavidKorczynski merged 1 commit intogoogle:masterfrom Jan 4, 2026
Merged
Conversation
|
illia-v is a new contributor to projects/urllib3. The PR must be approved by known contributors before it can be merged. The past contributors are: hunsche, sg3-141-592, sethmlarson, pquentin, TheShiftedBit, fmeum |
DavidKorczynski
approved these changes
Jan 4, 2026
Contributor
Author
|
@DavidKorczynski thanks for the review! The build succeeded today https://oss-fuzz-build-logs.storage.googleapis.com/index.html#urllib3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
urllib3's
fuzz_requestshas been broken for over a year because it uses HTTPretty which does not support modern urllib3 gabrielfalcao/HTTPretty#485.In this PR, I'm replacing HTTPretty with a simple server in a separate thread, the approach is borrowed from a httpx fuzzer.
Also, I'm adding myself as the primary contact for urllib3 because I'm its current lead maintainer.