Fix context leak in cms_transform_extended_fuzzer#15076
Open
OwenSanzas wants to merge 1 commit intogoogle:masterfrom
Open
Fix context leak in cms_transform_extended_fuzzer#15076OwenSanzas wants to merge 1 commit intogoogle:masterfrom
OwenSanzas wants to merge 1 commit intogoogle:masterfrom
Conversation
cmsCreateContext is called at line 106 but cmsDeleteContext is never called on any code path. This leaks a context on every fuzzer iteration, causing unbounded memory growth and O(n) performance degradation in lcms2's internal context linked list. Fix: add cmsDeleteContext(ctx) on both the error path (transform creation failure) and the normal exit path.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
OwenSanzas is a new contributor to projects/lcms. The PR must be approved by known contributors before it can be merged. The past contributors are: hunsche, zzjas, viktoriia-lsg, rjotwani, cvediver, Dor1s, inferno-chromium (unverified) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15072
Summary
Add missing
cmsDeleteContext(ctx)calls on both the error path (transform creation failure) and the normal exit path incms_transform_extended_fuzzer.c.Changes
cmsDeleteContext(ctx)whencmsCreateTransformTHRfails (line 118-121)cmsDeleteContext(ctx)aftercmsDeleteTransformon normal exit (line 156)Impact
Without the fix, every fuzzer iteration leaks a context into lcms2's global linked list, causing unbounded memory growth (~600 bytes/iteration) and O(n) performance degradation in
_cmsGetContext().