Skip to content

feat: Skip writing import findings at import time, just do it during … #3811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: Skip writing import findings at import time, just do it during … #3811

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4acfb97
feat: Skip writing import findings at import time, just do it during …
another-rex Aug 15, 2025
06247a5
Comment out findings to avoid lint
another-rex Aug 15, 2025
69bb470
Use a global variable instead
another-rex Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions gcp/workers/importer/importer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
_BUCKET_THREAD_COUNT = 20
_HTTP_LAST_MODIFIED_FORMAT = '%a, %d %b %Y %H:%M:%S %Z'
_TIMEOUT_SECONDS = 60
_STORE_QUALITY_FINDINGS = False

_client_store = threading.local()

Expand Down Expand Up @@ -265,6 +266,12 @@ def _record_quality_finding(
findings for the record (if any already exist)
"""

# TODO: Do not write import findings at import time, as it could cause
# confusing results.
# We run osv-linter daily on all records and populate
# the linting bucket.
if not _STORE_QUALITY_FINDINGS:
return
# Get any current findings for this record.
findingtimenow = utcnow()
if existing_finding := osv.ImportFinding.get_by_id(bug_id):
Expand Down
Loading