Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
🎨 Perfetto UI Builds
|
zezeozue
force-pushed
the
dev/zezeozue/dev/zezeozue/ahat-split
branch
4 times, most recently
from
6e78165 to
10cfef5
Compare
Add heap_graph_object_data and heap_graph_primitive tables for HPROF heap dumps. Add __intrinsic_heap_graph_get_array() SQL function to retrieve raw primitive array bytes by blob ID. Remove GenerateArrayValueStrings() which created multi-MB interned strings for large arrays. Change-Id: Iba8909797f89aec4cf43c7b0f8c9a68c6efeb615
Add the com.android.Ahat plugin with navigation, shared components, queries, and the overview dashboard for HPROF heap dumps. Change-Id: I28d4f8ef7b3b949e2e1a5fefe3aeefddab2b3c5f
Adds all the remaining Ahat views: objects list, search, rooted objects, allocations, string list, bitmap gallery, and detailed object view with field inspection, path from root, and dominator tree. Change-Id: I13039d396d75ae6fa4c295132c7c11ab63f28d76
Adds size columns (shallow, native, retained, reachable) across all Ahat views. Adds flamegraph-to-Ahat navigation and removes legacy reference table options from the flamegraph context menu. Introduces mapCol utility for adapting shared column definitions. Change-Id: I6b3f522f5d5a82822decf247ce9b672941fe086a
zezeozue
force-pushed
the
dev/zezeozue/dev/zezeozue/ahat-split
branch
from
10cfef5 to
e416a81
Compare
stevegolton
left a comment
stevegolton
left a comment
There was a problem hiding this comment.
Haven't finished going through everything yet but I noticed you were duplicating a lot of widgets and styles - please use the builtin ones to avoid bloating the bundle and to offer a consistient look and feel.
| from dataclasses import dataclass | ||
|
|
||
| EXPECTED_ANY_COUNT = 29 | ||
| EXPECTED_ANY_COUNT = 32 |
There was a problem hiding this comment.
Can we avoid incrementing this number please? Use unknown if you can
| title: 'Current Trace', | ||
| summary: 'Actions on the current trace', | ||
| }, | ||
| ahat: { |
There was a problem hiding this comment.
I don't think we want to have a specifc AHAT section in the sidebar, it's a bit too specific.
If you want subpages, add subtabs or a sub menu within the page itself.
|
|
||
| // ─── Theme tokens ──────────────────────────────────────────────────────────── | ||
|
|
||
| :root { |
There was a problem hiding this comment.
Please use the builtin theme colors.
| }); | ||
| } | ||
|
|
||
| constructor(_trace: Trace) {} |
| ? m('div', {class: 'ah-card--compact ah-mb-3'}, [ | ||
| m('span', {class: 'ah-info-grid__label'}, 'Heap: '), | ||
| m( | ||
| 'select', |
There was a problem hiding this comment.
Pleas use the builtin select widget
| {class: 'ah-table-wrap'}, | ||
| m( | ||
| 'table', | ||
| {class: 'ah-table'}, |
2 participants
DO NOT SUBMIT