Open
Conversation
This reverts commit b723d21. Simplifying the track names might make them harder to read, so I'm kicking this can down the road for now.
🎨 Perfetto UI Builds
|
LalitMaganti
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you pin a track, it doesn't show any context about where it came from. For process-scoped tracks such as thread state or counter tracks, their process context is lost.
The fix is to make pinned tracks show the full path, but first we need to change how pinned tracks work. Currently, pinned tracks are a separate mini workspace, and each TrackNode in it is a standalone TrackNode. When we pin, we take a complete copy of the node and add that copy to the pinned tracks workspace.
This patch changes how this works, so that pinned tracks are actually references to TrackNodes in the workspace.
This does also involve changing debug tracks and some plugins which added tracks to the pinned area directly, as we now must add a track or group to the workspace first before it can be pinned, but the result is the same.
Before:
After:
