Minor improvements to the dataclasses overlay #1939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
cl/826079562
branch
from
7c81336 to
c69fa21
Compare
* Relaxed type checking for dataclasses with unknown/dynamic base classes. The set of fields for such dataclasses is unknown, so we cannot precisely check instantiation and `dataclasses.replace` calls. * Allowed inheriting `__match_args__`. * Ensured that `kw_only=` fields are excluded from `__match_args__`. PiperOrigin-RevId: 826512868
copybara-service
bot
force-pushed
the
cl/826079562
branch
from
c69fa21 to
9e87d0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvements to the dataclasses overlay
The set of fields for such dataclasses is unknown, so we cannot precisely
check instantiation and
dataclasses.replacecalls.__match_args__.kw_only=fields are excluded from__match_args__.