Refactor result handling in get_file_contents#134
Merged
panhania merged 1 commit intogoogle:masterfrom Jul 30, 2025
Merged
Conversation
s-westphal
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally I planned to extend
FakeSessionwith methods that returnAnyversion of replies that can be then inspected. But when I tried this approach it felt too dynamically typed to my taste. And the fact that we have two different result types that can be sent also feels off.So here I swap to approach that maybe feels a bit awkward but is actually simpler and more explicit. It adds a bit of extra boilerplate to tests but nothing too terrible, I think.