Write all request bytes in get_tcp_response#143
Merged
panhania merged 1 commit intogoogle:masterfrom Aug 29, 2025
Merged
Conversation
handle_non_empty_request_data() was flaky on macOS. I believe this was due to write truncation.
panhania
approved these changes
Aug 26, 2025
panhania
changed the title
get_tcp_response.get_tcp_response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_non_empty_request_data() was flaky on macOS. I believe this was due to write truncation. See e.g. this CI run