Skip to content

Clarify safety comment for GetMappedFileNameW #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
panhania merged 1 commit into from
Sep 15, 2025
Merged

Clarify safety comment for GetMappedFileNameW #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/rrg/src/action/dump_process_memory.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,12 @@ mod windows {
let mut buf = [0u16; (MAX_PATH + 1) as usize];
// SAFETY: `GetMappedFileNameW` will only write up to `nSize` (last argument)
// characters in `buf` (null-terminator included). Therefore there can be no buffer overflow.
//
// The function [verifies][1] whether the given `addr` is within the
// process address space and thus we do not need to add aditional safety
// constraints on the parameter itself.
//
// [1]: https://learn.microsoft.com/en-us/windows/win32/api/psapi/nf-psapi-getmappedfilenamew#parameters
let len = unsafe { GetMappedFileNameW(process.0, addr, buf.as_mut_ptr(), buf.len() as u32) }
as usize;
// A return value of 0 indicates an error, and nSize indicates that the path was
Expand Down
Loading