Skip to content

Rename argument to snake_case. #11829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
Merged

Rename argument to snake_case. #11829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/phpunit/integration/Modules/Analytics_4/Datapoints/Create_Account_TicketTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ public function test_create_request_validates_required_params( $required_param )
/**
* @dataProvider data_create_account_ticket_show_progress
*/
public function test_create_request( $showProgressParams ) {
public function test_create_request( $show_progress_params ) {
$this->enable_feature( 'setupFlowRefresh' );

$this->provision_account_ticket_request = null;
Expand All @@ -160,8 +160,8 @@ public function test_create_request( $showProgressParams ) {
'timezone' => 'UTC',
);

if ( isset( $showProgressParams['provided'] ) ) {
$data['showProgress'] = $showProgressParams['provided'];
if ( isset( $show_progress_params['provided'] ) ) {
$data['showProgress'] = $show_progress_params['provided'];
}

$data_request = new Data_Request( 'POST', 'modules', 'analytics-4', 'create-account-ticket', $data );
Expand All @@ -176,7 +176,7 @@ public function test_create_request( $showProgressParams ) {
$this->assertEquals( 'US', $account_ticket_request->getAccount()->getRegionCode(), 'Account region code should match the provided value.' );
$redirect_uri = $this->authentication->get_google_proxy()->get_site_fields()['analytics_redirect_uri'];

if ( $showProgressParams['expected'] ) {
if ( $show_progress_params['expected'] ) {
$redirect_uri = add_query_arg( 'show_progress', 1, $redirect_uri );
}

Expand Down