Skip to content

docs: clarify map(parseInt) example with explicit radix #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: gh-pages
Choose a base branch
from
Open

docs: clarify map(parseInt) example with explicit radix #916

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b78f07
docs: clarify map(parseInt) example with explicit radix
KeenoLee Apr 22, 2025
bbb2306
Merge branch 'google:gh-pages' into gh-pages
KeenoLee Apr 24, 2025
8d0c19f
docs: simplify GOOD callback comment
KeenoLee Apr 24, 2025
fe6b372
Merge branch 'gh-pages' into gh-pages
KeenoLee May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tsguide.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1561,8 +1561,8 @@ <h4 id="functions-as-callbacks" class="numbered">Prefer passing arrow functions
<p>Instead, prefer passing an arrow-function that explicitly forwards parameters to
the named callback.</p>

<pre><code class="language-ts good">// GOOD: Arguments are explicitly passed to the callback
const numbers = ['11', '5', '3'].map((n) =&gt; parseInt(n));
<pre><code class="language-ts good">// GOOD: we only forward the string (and an explicit radix)
const numbers = ['11', '5', '3'].map((n) =&gt; parseInt(n,10));
// &gt; [11, 5, 3]

// GOOD: Function is locally defined and is designed to be used as a callback
Expand Down