Report os_signposts on Darwin, split warmup reporting#95
Open
karwa wants to merge 1 commit intogoogle:mainfrom
Open
Report os_signposts on Darwin, split warmup reporting#95karwa wants to merge 1 commit intogoogle:mainfrom
karwa wants to merge 1 commit intogoogle:mainfrom
Conversation
Author
|
Ping @compnerd @shabalind Would you mind triggering the tests and reviewing? Whenever you get a chance, no rush. Thanks. |
Contributor
|
Would you mind splitting this up into two separate changes? Addition of the signposts should be simple and straight forward, and then we can look at the structural changes for the split warmup separately. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does 2 things:
os_signpostreporting on platforms whereOSLogis available, so Instruments can show which benchmark is running at which time, and similarly split that in to warmup/benchmark sections: