Skip to content

Clippy#517

Merged
tikue merged 2 commits intogoogle:masterfrom
dtolnay-contrib:clippy
Mar 26, 2025
Merged

Clippy#517
tikue merged 2 commits intogoogle:masterfrom
dtolnay-contrib:clippy

Conversation

@dtolnay
Copy link
Copy Markdown
Contributor

@dtolnay dtolnay commented Mar 26, 2025

A clippy CI job blocked #515 from being merged.

warning: the following explicit lifetimes could be elided: 'a
   --> plugins/src/lib.rs:535:6
    |
535 | impl<'a> ServiceGenerator<'a> {
    |      ^^                   ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
    |
535 - impl<'a> ServiceGenerator<'a> {
535 + impl ServiceGenerator<'_> {
    |

warning: the following explicit lifetimes could be elided: 'a
   --> plugins/src/lib.rs:811:6
    |
811 | impl<'a> ToTokens for ServiceGenerator<'a> {
    |      ^^                                ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
811 - impl<'a> ToTokens for ServiceGenerator<'a> {
811 + impl ToTokens for ServiceGenerator<'_> {
    |

warning: very complex type used. Consider factoring parts into `type` definitions
   --> tarpc/examples/tracing.rs:123:6
    |
123 |   ) -> retry::Retry<
    |  ______^
124 | |     impl Fn(&Result<Resp, RpcError>, u32) -> bool + Clone,
125 | |     load_balance::RoundRobin<client::Channel<Arc<Req>, Resp>>,
126 | | >
    | |_^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
    = note: `#[warn(clippy::type_complexity)]` on by default

dtolnay added 2 commits March 26, 2025 12:20
    warning: the following explicit lifetimes could be elided: 'a
       --> plugins/src/lib.rs:535:6
        |
    535 | impl<'a> ServiceGenerator<'a> {
        |      ^^                   ^^
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
        = note: `#[warn(clippy::needless_lifetimes)]` on by default
    help: elide the lifetimes
        |
    535 - impl<'a> ServiceGenerator<'a> {
    535 + impl ServiceGenerator<'_> {
        |

    warning: the following explicit lifetimes could be elided: 'a
       --> plugins/src/lib.rs:811:6
        |
    811 | impl<'a> ToTokens for ServiceGenerator<'a> {
        |      ^^                                ^^
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    help: elide the lifetimes
        |
    811 - impl<'a> ToTokens for ServiceGenerator<'a> {
    811 + impl ToTokens for ServiceGenerator<'_> {
        |
    warning: very complex type used. Consider factoring parts into `type` definitions
       --> tarpc/examples/tracing.rs:123:6
        |
    123 |   ) -> retry::Retry<
        |  ______^
    124 | |     impl Fn(&Result<Resp, RpcError>, u32) -> bool + Clone,
    125 | |     load_balance::RoundRobin<client::Channel<Arc<Req>, Resp>>,
    126 | | >
        | |_^
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
        = note: `#[warn(clippy::type_complexity)]` on by default
@tikue
Copy link
Copy Markdown
Collaborator

tikue commented Mar 26, 2025

Thank you!

@tikue tikue enabled auto-merge March 26, 2025 20:09
@tikue tikue disabled auto-merge March 26, 2025 20:11
@tikue tikue enabled auto-merge March 26, 2025 20:12
@tikue tikue disabled auto-merge March 26, 2025 20:15
@tikue tikue merged commit 502a9df into google:master Mar 26, 2025
30 of 32 checks passed
@dtolnay dtolnay deleted the clippy branch March 26, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants