Skip to content

Move INFO level traces to DEBUG#537

Merged
tikue merged 2 commits intogoogle:mainfrom
azdle:trace-debug-not-info
Oct 1, 2025
Merged

Move INFO level traces to DEBUG#537
tikue merged 2 commits intogoogle:mainfrom
azdle:trace-debug-not-info

Conversation

@azdle
Copy link
Copy Markdown
Contributor

@azdle azdle commented Oct 1, 2025

INFO level traces/logs are usually reserved for the application.

All of the existing INFO level traces were changed, except for those in examples.

resolves #536

INFO level traces/logs are usually reserved for the application.

All of the existing INFO level traces were changed, except for those in
examples.

resolves google#536
@google-cla
Copy link
Copy Markdown

google-cla bot commented Oct 1, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@azdle
Copy link
Copy Markdown
Contributor Author

azdle commented Oct 1, 2025

The clippy error seem to be caused by 73dcdaa, which itself says is fixing clippy errors.

I'm not sure why the io::Error::other changes were made, but if I revert those three changes clippy is happy. I've tacked that commit on here, if you want it.

@tikue
Copy link
Copy Markdown
Collaborator

tikue commented Oct 1, 2025

Thanks for the PR! Let me address the clippy error — it's due to another commit I didn't upstream yet.

@tikue
Copy link
Copy Markdown
Collaborator

tikue commented Oct 1, 2025

I think things should be good once 8655a73 is removed

@azdle azdle force-pushed the trace-debug-not-info branch from 8655a73 to e3e4644 Compare October 1, 2025 17:02
@azdle
Copy link
Copy Markdown
Contributor Author

azdle commented Oct 1, 2025

Removed, though it looks like main is still failing.

@tikue tikue added this pull request to the merge queue Oct 1, 2025
Merged via the queue into google:main with commit 0b3352a Oct 1, 2025
32 checks passed
@azdle azdle deleted the trace-debug-not-info branch October 1, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Info-level traces Debug

2 participants