-
Notifications
You must be signed in to change notification settings - Fork 209
Proposal: Add MODIFIED and pickup and drop-off types to GTFS-RT; experimentally deprecate SKIPPED #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ericouyang
wants to merge
17
commits into
google:master
from
SwiftlyInc:gtfs-servicechanges-v3.1-pickupdropofftypes
Closed
Proposal: Add MODIFIED and pickup and drop-off types to GTFS-RT; experimentally deprecate SKIPPED #265
Changes from 5 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2faa3df
Add pick-up and drop-off types
ericouyang b28420b
Update documentation
ericouyang 898c1a3
Document TripUpdates V3
ericouyang 9a57863
Revert "Document TripUpdates V3"
ericouyang bf8bfa7
Add migration approach
ericouyang 591ddd8
Fix typo
ericouyang 16e412f
Update language to adhere to RFC 2119
ericouyang c475594
Address PR feedback
ericouyang 89993cc
Mark SKIPPED as deprecated
ericouyang 19fc85f
Update migration guide
ericouyang 107fb2a
Merge branch 'master' into gtfs-servicechanges-v3.1-pickupdropofftypes
ericouyang 780be36
Editorial clarifications
ericouyang e9ef94b
Reflect editorial changes into reference.md
ericouyang ab21cd6
No longer mark SKIPPED as formally deprecated
ericouyang 81c94d7
Update migration guide to support SCHEDULED
ericouyang 4ffaf3a
Support SCHEDULED in migration period
ericouyang d28f432
Update reference to match documentation in .proto
ericouyang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| ## Migration Guide - Transition from SKIPPED to MODIFIED | ||
|
|
||
| The GTFS-realtime `StopTimeUpdate.schedule_relationship` of `SKIPPED` indicates that a vehicle will not be serving a particular stop that was originally scheduled as a part of `stop_times.txt` in GTFS-static. | ||
|
|
||
| The GTFS-static `pickup_type` and `drop_off_type` fields within `stop_times.txt` allow an agency to specify details on what a rider needs to do in order to board/alight at a given stop (e.g. a rider must explicitly request a drop-off at a stop, otherwise the driver will skip the stop). | ||
|
|
||
| This migration guide defines how existing producers who use the `SKIPPED` enumeration as a best approximation of partial service at a stop can provide a more nuanced picture of the level of service through `pickup_type` and `drop_off_type` via `StopTimeProperties`. The goal is to minimize disruption to producers and consumers during the transition. | ||
|
|
||
| See the [Add pickup and drop-off types to GTFS-RT proposal on GitHub](https://github.com/google/transit/pull/265). | ||
|
|
||
| ### Initially providing SKIPPED and pickup_type / drop_off_type in same feed | ||
|
|
||
| #### Producers | ||
|
|
||
| If you are a producer who uses the `SKIPPED` enumeration as a best approximation of partial service at a stop, to avoid disruption to existing consumers, it is recommended that you continue to produce `SKIPPED` entities for those stop time updates but also add `pickup_type` and `drop_off_type` entities for the same `StopTimeUpdate`. | ||
|
|
||
| Here's an example of indicating to consumers that a vehicle will be "drop-off only": | ||
|
|
||
| ~~~ | ||
| entity { | ||
| id: "ei0" | ||
| trip_update { | ||
| ... | ||
| stop_time_update { | ||
| ... | ||
| schedule_relationship: SKIPPED | ||
| stop_time_properties { | ||
| pickup_type: NO_PICKUP | ||
| drop_off_type: MUST_ASK_DRIVER_DROP_OFF | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ~~~ | ||
|
|
||
| It is suggested that you notify existing consumers (e.g., via a developer mailing list) that the use of `SKIPPED` for partial service at a stop is being deprecated in favor of more nuanced information by a set deadline and that consumers should start consuming the `MODIFIED` enumeration as well as `pickup_type` and `drop_off_type`. You should also provide a link to this migration guide. After the deadline passes, you can stop using `SKIPPED` entities for scenarios where `pickup_type` or `drop_off_typ` are included and start using `MODIFIED` instead. | ||
ericouyang marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| #### Consumers | ||
| `pickup_type` and `drop_off_type` set in `StopTimeProperties` takes precedence over `schedule_relationship=SKIPPED`, meaning that real-time arrival information should still be used to inform passengers rather being ignored, perhaps with additional instructions or notification on how to board/alight, similar to what may happen with those fields being specified in `stop_times.txt`. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.