Skip to content

go update to 1.23#3733

Merged
phbnf merged 5 commits intogoogle:masterfrom
phbnf:goupdate
Feb 13, 2025
Merged

go update to 1.23#3733
phbnf merged 5 commits intogoogle:masterfrom
phbnf:goupdate

Conversation

@phbnf
Copy link
Contributor

@phbnf phbnf commented Feb 13, 2025

go update to 1.23
golanci-lint update to 1.61.0, together with minor code changes to make it happy.

Will unblock #3732

Checklist

@phbnf phbnf requested a review from a team as a code owner February 13, 2025 11:18
@phbnf phbnf requested review from roger2hk and removed request for roger2hk February 13, 2025 11:18
@phbnf phbnf marked this pull request as draft February 13, 2025 11:23
@phbnf
Copy link
Contributor Author

phbnf commented Feb 13, 2025

  Error: monitoring/testonly/metrics.go:74:7: S1009: should omit nil check; len() for []string is defined as zero (gosimple)
  			if test.labelVals != nil && len(test.labelVals) >= 1 {
  			   ^
  Error: monitoring/testonly/metrics.go:154:7: S1009: should omit nil check; len() for []string is defined as zero (gosimple)
  			if test.labelVals != nil && len(test.labelVals) >= 1 {
  			   ^
  Error: monitoring/testonly/metrics.go:226:7: S1009: should omit nil check; len() for []string is defined as zero (gosimple)
  			if test.labelVals != nil && len(test.labelVals) >= 1 {
  			   ^
  Error: server/errors/errors.go:28:40: printf: non-constant format string in call to google.golang.org/grpc/status.Errorf (govet)
  		return status.Errorf(codes.NotFound, err.Error())
  		                                     ^
  Error: server/errors/errors_test.go:45:43: printf: non-constant format string in call to google.golang.org/grpc/status.Errorf (govet)
  			wantErr: status.Errorf(codes.NotFound, sql.ErrNoRows.Error()),
 			```

@phbnf phbnf marked this pull request as ready for review February 13, 2025 12:34
@phbnf phbnf requested a review from roger2hk February 13, 2025 12:34
@phbnf phbnf merged commit 1f8ca96 into google:master Feb 13, 2025
12 checks passed
tommyd450 pushed a commit to securesign/trillian that referenced this pull request Mar 18, 2025
* go update to 1.23

* update changelog

* update README.md

* update golangci-lint

* fix golangci-lint
tommyd450 pushed a commit to securesign/trillian that referenced this pull request Mar 18, 2025
* go update to 1.23

* update changelog

* update README.md

* update golangci-lint

* fix golangci-lint
JasonPowr pushed a commit to securesign/trillian that referenced this pull request Mar 21, 2025
* go update to 1.23

* update changelog

* update README.md

* update golangci-lint

* fix golangci-lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants