Skip to content

add optional gRPC max message size limit to trillian logserver and logsigner#3801

Merged
mhutchinson merged 2 commits intogoogle:masterfrom
fghanmi:trillian/optional_max_request_message_size
Aug 5, 2025
Merged

add optional gRPC max message size limit to trillian logserver and logsigner#3801
mhutchinson merged 2 commits intogoogle:masterfrom
fghanmi:trillian/optional_max_request_message_size

Conversation

@fghanmi
Copy link
Contributor

@fghanmi fghanmi commented Aug 4, 2025

Description

This change introduces a new optional flag --max_msg_size_bytes to both Trillian logsigner and logserver.

When set to a positive value, the flag enables a gRPC server-side limit on the size of incoming messages using grpc.MaxRecvMsgSize(). This provides a safeguard against resource exhaustion and potential denial-of-service (DoS) attacks caused by overly large client requests.

If the flag is unset or set to 0, no message size limit is enforced, preserving backward compatibility with existing deployments.

This change is non-breaking by design and is disabled by default.

Checklist

…gsigner

Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
@fghanmi fghanmi requested a review from a team as a code owner August 4, 2025 11:23
@fghanmi fghanmi requested a review from phbnf August 4, 2025 11:23
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
@mhutchinson
Copy link
Contributor

/gcbrun

@mhutchinson mhutchinson merged commit 985e78d into google:master Aug 5, 2025
12 checks passed
fghanmi added a commit to securesign/trillian that referenced this pull request Aug 5, 2025
…gsigner (google#3801)

* add optional gRPC max message size limit to trillian logserver and logsigner

Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>

* update CHANGELOG.md

Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>

---------

Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
fghanmi added a commit to securesign/trillian that referenced this pull request Aug 5, 2025
…gsigner (google#3801) (#427)

* add optional gRPC max message size limit to trillian logserver and logsigner



* update CHANGELOG.md



---------

Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
himaschal pushed a commit to digicert/trillian that referenced this pull request Jan 23, 2026
…gsigner (google#3801)

* add optional gRPC max message size limit to trillian logserver and logsigner

Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>

* update CHANGELOG.md

Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>

---------

Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants