-
Notifications
You must be signed in to change notification settings - Fork 214
add tikiwiki CVE-2025-34111 templated plugins #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tikiwiki CVE-2025-34111 templated plugins #696
Conversation
|
Hi @tooryx, my detector is running well now, but i have problem with the unit test, is any ways to debut unit test? always FAILED during test, even i tried as as simple as i can on the mock up response |
|
Hi, I think you can use |
|
Hi @crackatoa, As @am0o0 mentioned, you can enable debug mode. I am not often using gradle to run tests, but I think it generates an HTML file in which you can see more details. ~tooryx |
|
It tries to verify that a detector is not flaky. But I think there is a bug right now. If it is the only failing test, feel free to ignore it. ~tooryx |
|
Hi @tooryx, I tried to manually debug the unit test, i found that the test failed when i used {{ payload }} on my uri or body_content Still can't find the root cause, even when i tried payyload with static value, i will left/ignore the unit test as is for now |
savio-doyensec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @crackatoa, I left some suggestions to improve the detector.
As you said, the whenVulnerable_returnsTrue does not work because the payload variable is not propagated to the tests. For now, you can specify an hardcoded path for the PHP file, something like tsunami_security_scan.php, and use that instead of {{ payload }} for all the paths. You can keep {{ payload }} in the echo command inside the PHP.
templated/templateddetector/plugins/cve/2025/Tikiwiki_CVE_2025_34111.textproto
Outdated
Show resolved
Hide resolved
templated/templateddetector/plugins/cve/2025/Tikiwiki_CVE_2025_34111.textproto
Outdated
Show resolved
Hide resolved
templated/templateddetector/plugins/cve/2025/Tikiwiki_CVE_2025_34111.textproto
Outdated
Show resolved
Hide resolved
templated/templateddetector/plugins/cve/2025/Tikiwiki_CVE_2025_34111.textproto
Outdated
Show resolved
Hide resolved
templated/templateddetector/plugins/cve/2025/Tikiwiki_CVE_2025_34111.textproto
Outdated
Show resolved
Hide resolved
templated/templateddetector/plugins/cve/2025/Tikiwiki_CVE_2025_34111.textproto
Outdated
Show resolved
Hide resolved
…_34111.textproto Co-authored-by: Savio Sisco <[email protected]>
…_34111.textproto Co-authored-by: Savio Sisco <[email protected]>
…_34111.textproto Co-authored-by: Savio Sisco <[email protected]>
…_34111.textproto Co-authored-by: Savio Sisco <[email protected]>
…_34111.textproto Co-authored-by: Savio Sisco <[email protected]>
…_34111.textproto Co-authored-by: Savio Sisco <[email protected]>
|
Hi @savio-doyensec, Thanks for corrections, I have change {{ payload }}.php to static url, and it works. |
|
Hi @crackatoa, FYI, the test issue with the echo server should have been fixed with ebbd193 ~tooryx |
savio-doyensec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @crackatoa, I just have one more small change request for tidiness, everything else works fine.
templated/templateddetector/plugins/cve/2025/Tikiwiki_CVE_2025_34111_test.textproto
Outdated
Show resolved
Hide resolved
…_34111_test.textproto Co-authored-by: Savio Sisco <[email protected]>
|
Hi @savio-doyensec, done, please check |
|
@tooryx, I didnt found any issue anymorr on my latest template engine Thank you |
savio-doyensec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tooryx we can merge this and google/security-testbeds#161
Reviewer: Savio (Doyensec)
Plugin: CVE-2025-34111
Drawbacks: None
Hi,
This PR contains implementation of tikiwiki CVE-2025-34111
Below it is possible to find the necessary information for review:
PR Testbed: google/security-testbeds#161
Issue: #678
Thank you