[Tunix] Remove eos token from user config. use default tokenizer.eos_id() directly. Besides for deepseek-distilled model we should have used <|end_of_sentence|> instead.#1267
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 19, 2026
Conversation
copybara-service
bot
requested review from
abheesht17,
hgao327,
jiangyangmu,
lc5211,
sizhit2,
tianshub and
wang2yn84
as code owners
copybara-service
bot
force-pushed
the
test_886267374
branch
from
91bb9f6 to
d3b896f
Compare
copybara-service
bot
changed the title
<|end_of_sentence|> instead.<|end_of_sentence|> instead.
…id() directly. Besides for deepseek-distilled model we should have used `<|end_of_sentence|>` instead. PiperOrigin-RevId: 886312244
copybara-service
bot
force-pushed
the
test_886267374
branch
from
d3b896f to
ca54adb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Tunix] Remove eos token from user config. use default tokenizer.eos_id() directly. Besides for deepseek-distilled model we should have used
<|end_of_sentence|>instead.