security: replace eval() with safe AST math evaluator in calculate reward#1279
Open
RaymondSeven wants to merge 1 commit intogoogle:mainfrom
Open
security: replace eval() with safe AST math evaluator in calculate reward#1279RaymondSeven wants to merge 1 commit intogoogle:mainfrom
RaymondSeven wants to merge 1 commit intogoogle:mainfrom
Conversation
…ward
Replace the unsafe eval() call in calculate_reward() with a safe
AST-based mathematical expression evaluator that only permits numeric
literals and basic arithmetic operators (+, -, *, /, //, %, **).
The eval() call allowed arbitrary code execution via crafted dataset
inputs (e.g. task['question'] containing __import__('os').system(...)).
The new _safe_eval_math() function parses expressions into an AST and
walks only ast.Constant, ast.BinOp, and ast.UnaryOp nodes, raising
ValueError for anything else.
Also adds parameterized test cases verifying that code injection
payloads are safely rejected.
Bug: b/495205094
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves b/495205094
Summary
Replace the unsafe
eval()call incalculate_reward()with a safe AST-basedmathematical expression evaluator. The
eval()on line 192 oftunix/rl/agentic/rewards/reward.pyallowed arbitrary code execution viacrafted dataset inputs (e.g.
task["question"]containing__import__('os').system(...)).Changes
tunix/rl/agentic/rewards/reward.py_safe_eval_math()function that parses expressions into an AST andonly evaluates
ast.Constant(int/float),ast.BinOp, andast.UnaryOpnodes with a whitelist of arithmetic operators
eval(expression)with_safe_eval_math(expression)incalculate_reward()tests/rl/agentic/rewards/reward_test.pytest_calculate_reward_rejects_code_injectionwith 5 parameterizedpayloads (
__import__,eval(),open(), dunder class traversal)test_calculate_rewardcases continue to pass