Skip to content

Add advantage filter.#1280

Open
wang2yn84 wants to merge 1 commit intomainfrom
lance-grpo-filter
Open

Add advantage filter.#1280
wang2yn84 wants to merge 1 commit intomainfrom
lance-grpo-filter

Conversation

@wang2yn84
Copy link
Collaborator

This PRs filters out all 0 advantage groups so that it doesn't dilute the loss aggregation.

Reference

Colab Notebook

Checklist

  • I have added all the necessary unit tests for my change.
  • I have verified that my change does not break existing code and all unit tests pass.
  • I have added all appropriate doc-strings/documentation.
  • My PR is based on the latest changes of the main branch (if unsure, rebase the code).
  • I have signed the Contributor License Agreement.
  • I have followed Contribution Guidelines.

copybara-service bot pushed a commit that referenced this pull request Mar 23, 2026
--
6521ede by wang2yn84 <lancewang@google.com>:

Addadvantage filter.

COPYBARA_INTEGRATE_REVIEW=#1280 from google:lance-grpo-filter 6521ede
PiperOrigin-RevId: 888273183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants