Skip to content
This repository was archived by the owner on Jun 25, 2025. It is now read-only.

Minify inline #823

Open
javdl wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Minify inline #823

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fbcafef
minify styles & scripts which are placed inline. For example the Goog…
javdl Feb 2, 2016
76af76f
Strip JS comments and use better CSS attribute name
javdl Feb 3, 2016
278c4b7
Remove handlebars exclusion, simply because there is no handlebars us…
javdl Feb 3, 2016
11846bb
Merge branch 'master' into minify-inline
javdl Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions gulpfile.babel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,18 @@ gulp.task('html', () => {
removeStyleLinkTypeAttributes: true,
removeOptionalTags: true
})))
.pipe($.if('*.html', $.minifyInline({
js: {
output: {
comments: true
Copy link
Contributor

@surma surma Feb 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, this keeps the comments in the output. I don‘t think a production build should have comments.

}
},
jsSelector: 'script[type!="text/x-handlebars-template"]',
Copy link
Contributor

@Garbee Garbee Feb 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, we don't use handlebars in the project. We shouldn't add exclusions to things not used in the repo.

Copy link
Contributor

@Garbee Garbee Feb 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This either needs to be removed or we need to do something custom like the cssSelector one. We should not have ignores for things our repo doesn't use.

css: {
keepSpecialComments: 1
},
cssSelector: 'style[do-not-minify!="true"]'
Copy link
Contributor

@Garbee Garbee Feb 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data-do-not-minify would be a better attribute name to use. Data attributes exist for custom things like this.

Copy link
Contributor

@surma surma Feb 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Just for context, both this and the handlebar exclusion are straight up from the gulp-minify-inline README.

})))
// Output files
.pipe($.if('*.html', $.size({title: 'html', showFiles: true})))
.pipe(gulp.dest('dist'));
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"gulp-if": "^2.0.0",
"gulp-imagemin": "^2.0.0",
"gulp-load-plugins": "^1.0.0",
"gulp-minify-inline": "^0.1.1",
"gulp-newer": "^1.0.0",
"gulp-sass": "^2.0.0",
"gulp-size": "^2.0.0",
Expand Down