Explicitly set ndkVersion to Flutter's#247
Merged
HamdaanAliQuatil merged 1 commit intogoogle:masterfrom Feb 10, 2026
Merged
Conversation
Without this, webcrypto.dart uses AGP's default NDK version, which can be different from Flutter's preferred NDK version. Apart from causing builds to download multiple NDKs needlessly, this also causes APKs to not use 16 KB page sizes. Tested by building an APK and opening it in Android Studio's APK analyzer.
This was referenced Jan 27, 2026
|
I was actually writing the same patch but you were first 😛 |
HamdaanAliQuatil
approved these changes
Feb 3, 2026
Collaborator
HamdaanAliQuatil
left a comment
HamdaanAliQuatil
left a comment
There was a problem hiding this comment.
thanks for this 🚀
jonasfj
approved these changes
Feb 5, 2026
delthas
added a commit
to irctoday/goguma
that referenced
this pull request
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, webcrypto.dart uses AGP's default NDK version, which can be different from Flutter's preferred NDK version. Apart from causing builds to download multiple NDKs needlessly, this also causes APKs to not use 16 KB page sizes.
Tested by building an APK and opening it in Android Studio's APK analyzer.
Closes: #239