Update rules_hdl to use more bzlmod deps. #3742
Draft
+139
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_861361594
branch
4 times, most recently
from
5c01f69 to
151fa6a
Compare
|
👋 Hi, I'm an automated AI code review bot. I ran some checks on this PR and found 1 point that might be worth attention (could be false positives, please use your judgment):
If you find these suggestions disruptive, you can reply "stop" , and I'll automatically skip this repository in the future. |
copybara-service
bot
force-pushed
the
test_861361594
branch
3 times, most recently
from
75f7366 to
977d824
Compare
This is in preparation to use parts of ortools that use eigen, which conflicts with how rules_hdl sets up ortools+eigen. While we're at it, let's bump to the latest rules_hdl. Related: hdl/bazel_rules_hdl#336 PiperOrigin-RevId: 861361594
copybara-service
bot
force-pushed
the
test_861361594
branch
from
977d824 to
434c449
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update rules_hdl to use more bzlmod deps.
This is in preparation to use parts of ortools that use eigen, which conflicts with how rules_hdl sets up ortools+eigen. While we're at it, let's bump to the latest rules_hdl.
Related: hdl/bazel_rules_hdl#336