Skip to content

Fix a shadow remote code execution #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tednoob17 wants to merge 2 commits into from
Closed

Fix a shadow remote code execution #1404

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6b5b98
Fix a shadow remote code execution
Tednoob17 Feb 11, 2026
0db411f
Update md.ts
Tednoob17 Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/md.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export function transformMarkdown(buf: Buffer | string): string {
let state = 'root'
let codeBlockEnd = ''
let prevLineIsEmpty = true
for (const line of bufToString(buf).split(/\r?\n/)) {
for (const line of bufToString(buf).split(/\r?\n|\r|\u2028|\u2029/)) {
Copy link
Collaborator

@antongolub antongolub Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's simplify a bit: /\r\n|[\n\r\u2028\u2029]/

Copy link
Author

@Tednoob17 Tednoob17 Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you test it ?

Copy link
Author

@Tednoob17 Tednoob17 Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it work

switch (state) {
case 'root':
if (tabRe.test(line) && prevLineIsEmpty) {
Expand Down